chore(deps-dev): bump vite from 7.3.1 to 8.0.3 in /app#511
Open
dependabot[bot] wants to merge 3 commits intostagingfrom
Open
chore(deps-dev): bump vite from 7.3.1 to 8.0.3 in /app#511dependabot[bot] wants to merge 3 commits intostagingfrom
dependabot[bot] wants to merge 3 commits intostagingfrom
Conversation
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 7.3.1 to 8.0.3. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/create-vite@8.0.3/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-version: 8.0.3 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
Completed Working on "Code Review"✅ Review publishing completed successfully. Posted all chunk comments and submitted final review. ✅ Workflow completed successfully. |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. OpenSSF ScorecardScorecard details
Scanned Files
|
![overcut-ai[bot]](https://avatars.githubusercontent.com/in/1367736?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
Found 1 MAJOR issue across 1 file (app/package-lock.json).
Key theme
- Toolchain compatibility risk from dependency major upgrade: Vite 8 transitively requires newer Node versions via
rolldownbindings, which can break installs/builds in environments still on older Node 20.x or Node 18.
Actionable next steps
- Update and enforce the project Node baseline (CI + local) to a compatible version (>=20.19.0 or >=22.12.0), e.g., via
.nvmrc,engines, and CI configuration. - If upgrading runtime baseline is not yet feasible, defer this Vite major bump to avoid install/runtime regressions.
| "engines": { | ||
| "node": ">=18.0.0", | ||
| "npm": ">=8.0.0" | ||
| "node": "^20.19.0 || >=22.12.0" |
There was a problem hiding this comment.
[major]: The regenerated lockfile brings in rolldown@1.0.0-rc.12 and platform bindings with engines: "^20.19.0 || >=22.12.0", while Vite 7 previously worked with Node 18+. CI/developer environments on Node 20.18.x (or older) will fail install/runtime after this merge, causing reproducibility/stability regressions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps vite from 7.3.1 to 8.0.3.
Release notes
Sourced from vite's releases.
... (truncated)
Changelog
Sourced from vite's changelog.
... (truncated)
Commits
f83264frefactor(build): renameindexOfMatchInSlicetofindPreloadMarker(#21054)8293de0release: v7.2.02833c55fix(types): add undefined to optional properties for exactOptionalProperties ...e3a6a83chore(deps): update rolldown-related dependencies (#21047)b1fd616fix(css): fallback to sass when sass-embedded platform binary is missing (#21...ad5b3bffix(module-runner): makegetBuiltinsresponse JSON serializable (#21029)793baa2release: v7.2.0-beta.1e5af352fix(optimizer): externalize virtual modules for html like files (#21001)4f44f22fix: increase stream reset rate limit for HTTP2 (#21024)a2df778refactor: usefs.cpSync(#21019)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)