More informative mishaps #951

Robotgiggle · 2025-10-10T03:03:00Z

Implements Add small type blurb to iota expected mishaps #950
Changes the invalid-pattern mishap to actually display the offending pattern

Common/src/main/java/at/petrak/hexcasting/api/casting/mishaps/MishapInvalidIota.kt

Common/src/main/resources/assets/hexcasting/lang/en_us.flatten.json5

object-Object · 2025-11-18T20:10:39Z

Common/src/main/java/at/petrak/hexcasting/api/casting/mishaps/MishapInvalidPattern.kt

 import net.minecraft.world.item.DyeColor

-class MishapInvalidPattern : Mishap() {
+class MishapInvalidPattern(val pattern: HexPattern) : Mishap() {


This is a breaking change. Do any addons throw this mishap? If so, there should be a fallback constructor taking no arguments.

What would be displayed via the fallback constructor? No / placeholder pattern?

GitHub search shows no matches except for HexMod and forks thereof, so I doubt that this would break addons. However, it is technically ABI-breaking, so some fallback would be safest.

Probably just the old message?

object-Object · 2025-11-19T02:49:07Z

Common/src/main/java/at/petrak/hexcasting/api/casting/mishaps/MishapInvalidPattern.kt

 import net.minecraft.world.item.DyeColor

-class MishapInvalidPattern : Mishap() {
+class MishapInvalidPattern(val pattern: HexPattern? = null) : Mishap() {


Can this be a separate constructor annotated with @Deprecated, instead of an optional argument?

object-Object · 2025-11-19T02:49:31Z

Common/src/main/java/at/petrak/hexcasting/api/casting/mishaps/MishapInvalidPattern.kt

-        error("invalid_pattern")
+    override fun errorMessage(ctx: CastingEnvironment, errorCtx: Context): Component? {
+        if (pattern == null) return error("invalid_pattern_generic")
+        else return error("invalid_pattern", PatternIota.display(pattern))


Nitpick: this else is unnecessary

ChloeTax · 2025-11-20T22:47:38Z

should this also apply to disallowed patterns?

Robotgiggle · 2025-11-21T05:16:43Z

Hmm yeah that's a good idea, totally forgot that mishap existed - I'll make a new PR for that sometime soon.

Robotgiggle · 2025-11-21T06:55:33Z

Created #970 to handle that. Note that MishapDisallowedAction is actually based on the action, not the pattern that triggered it, so the display I made for it is a little different.

## Added - Added several new player attributes (ported from [Hexxy Attributes](https://modrinth.com/mod/hexxyattributes)), by beholderface in [#823](#823). - Added ancient cyphers, by Robotgiggle in [#838](#838). - Added the ability for wandering traders to sell ancient scrolls, by Robotgiggle in [#837](#837). - Added a creative tab for ancient scrolls, by Robotgiggle in [#837](#837). - Added a config option to disable Greater Teleport item splatting, by TheDrawingCoding-Gamer in [#841](#841). - Added loot tables to generate exactly one random scroll/cypher, by Robotgiggle in [#844](#844). - Added recipes for slate, amethyst, and quenched allay blocks, by KyanBirb in [#903](#903). - hexdoc: Added the ability to load patterns from a JSON file (instead of scraping them from source code with regex), by object-Object in [#911](#911). - Added a new Ancient Pigment and changed the appearance of the default pigment, by Robotgiggle in [#912](#912). ## Changed - Updated the spell circle documentation to clarify their new behavior in 0.11.x, by Robotgiggle in [#814](#814). - Added the recipes for bamboo and cherry staves to the notebook entry, by Robotgiggle in [#814](#814). - Renamed the eval limit mishap from "Delve Too Deep" to "Lost in Thought", and updated the description and error message to match, by Robotgiggle in [#814](#814). - Updated zh_cn translations, by ChuijkYahus in [#799](#799), [#828](#828), [#847](#847), [#913](#913), [#953](#953), [#954](#954), and [#971](#971). - Added apostrophes to Compass' Purification in the notebook, by kineticneticat in [#867](#867). - Updated the description of Ignite to clarify that it works on all entities, by Robotgiggle in [#844](#844). - Improved documentation of iota embedding, by Robotgiggle in [#862](#862). - Documented the behaviour of the Shepherd Directrix when no boolean is present on the stack, by Robotgiggle in [#862](#862). - Changed vectors in the notebook to use parentheses rather than square brackets, by Robotgiggle in [#862](#862). - Changed the rarity of several post-enlightenment items, by Robotgiggle in [#860](#860). - API: Changed the base class of `Mishap` from `Throwable` to `RuntimeException` to reduce the likelihood of server crashes, by navarchus in [#933](#933). - API: Added `@Throws` annotation to several `Action` methods to allow Java pattern implementations to throw mishaps, by navarchus in [#935](#935). - Improved the documentation for the media cube, by object-Object in [#843](#843). - Changed Greater Teleport to mishap when a passenger is immune to teleportation, by Robotgiggle in [#916](#916). - Re-added the slate limit for spell circles, by Stickia in [#909](#909). - Renamed Inverse Tangent Purification II to Inverse Tangent Distillation, by Robotgiggle in [#921](#921). - Massively improved ru_ru translations, by JustS-js and LedinecMing in [#832](#832). - Changed the invalid-pattern mishap to display the offending pattern, by Robotgiggle in [#951](#951). - Changed the invalid-iota mishap to display the type of the offending iota along with the iota itself, by Robotgiggle in [#951](#951). ## Fixed - Fixed missing dependency metadata on CurseForge/Modrinth. - Fixed a freeze when rendering patterns in certain cases, by vgskye in [#800](#800). - Added a missing translation for `hexcasting.subtitles.casting.cast.fail`, by Robotgiggle in [#814](#814). - Fixed incorrect Amethyst Sconce block rotation, by Robotgiggle in [#814](#814). - Fixed Place Block not pulling items from the inventory when available, by garyantonyo in [#812](#812). - Fixed a broken link in A Primer On Vectors, by bearofbusiness in [#877](#877). - Fixed Impulse not increasing its cost for subsequent uses in one cast, by vgskye in [#853](#853). - Added a config option to enable commas between patterns in lists, by Robotgiggle in [#844](#844). - Fixed incorrect cost for Wayfarer's Flight, by Robotgiggle in [#844](#844). - Fixed a bug where some patterns would check for media requirements earlier than expected, by vgskye in [#855](#855). - Fixed some modded fake players being able to overcast infinitely for free, by vgskye in [#854](#854). - Fixed Negation Purification not working on numbers, by Robotgiggle in [#869](#869). - Added a missing translation for the `no_spell_circle` mishap, by Robotgiggle in [#862](#862). - Fixed allays sometimes becoming invulnerable when mindflayed, by navarchus in [#928](#928). - hexdoc: Improved the error message for missing patterns, by navarchus in [#931](#931). - Fixed incorrect rendering for rod variants of cyphers/trinkets/artifacts, by navarchus in [#936](#936). - Fixed several issues related to invalid/overlapping patterns, by object-Object in [#938](#938). - Fixed sticky teleportation (ie. teleporting passengers) not working (again), by Robotgiggle in [#916](#916). - Fixed Greater Teleport sometimes failing with a "moved wrongly" message, by Robotgiggle in [#916](#916). - Fixed incorrect face textures for the Empty and Shepherd Directrix, by Robotgiggle in [#921](#921). - Removed unnecessary error logs when activating a bound Cleric Impetus with its owner offline, by Robotgiggle in [#921](#921). - Fixed the Cleric Impetus becoming unbound when activated with its owner offline, by Robotgiggle in [#921](#921). - Fixed some directrices inadvertently accepting input from their output faces, by Robotgiggle in [#921](#921). - Added a missing translation for providing something other than an entity as the first input to Flay Mind, by Robotgiggle in [#921](#921). - Added several missing translations for config options, by Robotgiggle in [#921](#921). - Clarified the description of Division Distillation, by JustS-js in [#832](#832). - Fixed a bug where some patterns inconsistently checked the lower-north-west corner of blocks for ambit instead of the center, by YukkuriC in [#959](#959). - Fixed Erase Item cost not scaling with stack size, by PoolloverNathan in [#966](#966).

github-project-automation bot added this to Hex Casting Oct 10, 2025

github-project-automation bot moved this to 📋 Backlog in Hex Casting Oct 10, 2025

object-Object linked an issue Oct 10, 2025 that may be closed by this pull request

Add small type blurb to iota expected mishaps #950

Closed

object-Object reviewed Oct 10, 2025

View reviewed changes

Common/src/main/java/at/petrak/hexcasting/api/casting/mishaps/MishapInvalidIota.kt Outdated Show resolved Hide resolved

Robotgiggle force-pushed the mishap-verbosity branch 2 times, most recently from 80e6929 to 26ac9f3 Compare November 13, 2025 19:46

object-Object reviewed Nov 18, 2025

View reviewed changes

Common/src/main/resources/assets/hexcasting/lang/en_us.flatten.json5 Show resolved Hide resolved

object-Object reviewed Nov 18, 2025

View reviewed changes

Robotgiggle added 4 commits November 18, 2025 16:54

Make MishapInvalidPattern display the offending pattern

30d40f8

Make MishapInvalidIota display the type of the offending iota

3f61f24

Allow MishapInvalidIota to refer to null, garbage, and jump iotas

c332450

Add mishap verbosity changes to changelog

f22cffe

Robotgiggle force-pushed the mishap-verbosity branch from 26ac9f3 to f22cffe Compare November 18, 2025 21:58

Update CHANGELOG.md

936b42e

object-Object requested changes Nov 19, 2025

View reviewed changes

github-project-automation bot moved this from 📋 Backlog to 🏗 In progress in Hex Casting Nov 19, 2025

Code cleanup

e25f500

object-Object approved these changes Nov 19, 2025

View reviewed changes

object-Object added this pull request to the merge queue Nov 19, 2025

Merged via the queue into FallingColors:main with commit b1c029b Nov 19, 2025
7 of 8 checks passed

github-project-automation bot moved this from 🏗 In progress to ✅ Done in Hex Casting Nov 19, 2025

Robotgiggle deleted the mishap-verbosity branch November 19, 2025 04:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

More informative mishaps #951

More informative mishaps #951

Uh oh!

Robotgiggle commented Oct 10, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

object-Object Nov 18, 2025

Uh oh!

PoolloverNathan Nov 18, 2025

Uh oh!

PoolloverNathan Nov 18, 2025 •

edited

Loading

Uh oh!

object-Object Nov 18, 2025

Uh oh!

object-Object Nov 19, 2025 •

edited

Loading

Uh oh!

Robotgiggle Nov 19, 2025

Uh oh!

object-Object Nov 19, 2025

Uh oh!

Uh oh!

ChloeTax commented Nov 20, 2025

Uh oh!

Robotgiggle commented Nov 21, 2025

Uh oh!

Robotgiggle commented Nov 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

More informative mishaps #951

More informative mishaps #951

Uh oh!

Conversation

Robotgiggle commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

object-Object Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

PoolloverNathan Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

PoolloverNathan Nov 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

object-Object Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

object-Object Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Robotgiggle Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

object-Object Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ChloeTax commented Nov 20, 2025

Uh oh!

Robotgiggle commented Nov 21, 2025

Uh oh!

Robotgiggle commented Nov 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Robotgiggle commented Oct 10, 2025 •

edited

Loading

PoolloverNathan Nov 18, 2025 •

edited

Loading

object-Object Nov 19, 2025 •

edited

Loading