Fix node sizing #355
Closed
Fix node sizing #355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
#354 also addresses the same issue, favoring that instead of this change |
This was referenced Jul 3, 2015
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where the node does not size correctly because the scene is picking up the size instead of the Node. The Scene itself should not have a size since it is just an abstraction layer.
The fix involves placing the constant definitions within the constructor itself as defined in #353. Since the original constant
INIThad a value oftrue, it was only by chance that this working. (I think... )This could also be wrong, and the scene need sizing for something else, but this addresses the proportional sizing issues...