Open
Conversation
Add support for importing local settings for meteor checkout Allow specifying a local dev bundle tar file path Allow dev bundle version to be external to tar file to allow version to be derived from bundle hash Allow dev bundle output tar file path to be specified Allow local node binaries path to be specified Allow local mongo binaries path to be specified Allow npm version to not be updated as part of bundle build
This change improves build times significantly when large bare files are used.
… the client This significantly reduces message processing overhead.
This really should use the npm logic for what files should be included when publishing instead
…hronousCursor. This option isn't needed and would break the replaceTypes since it's a custom document type.
…cept a promise and apply that to accounts and startup code.
matheusccastroo
force-pushed
the
fav-132786-v2
branch
from
c66df17 to
4bc4ce2
Compare
matheusccastroo
force-pushed
the
fav-132786-v2
branch
from
62384a5 to
aeee53a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had to do a couple of changes on the meteor side, more specifically adding the
asyncAPI forAssetsand ensuring the loop actions from cursors correctly waitasyncmethods.The approach with the
wrapFnwas selected because it reduces noise through the code, so we don't need to find where each callback is called and wrap it with aPromise.await, instead we can just change the definition to wait automatically for us when needed and not break simulations/client/shared code.