Merge the Updated Codebase

[Linardos]

No description provided.

[gitguardian]

⚠️ GitGuardian has uncovered 5 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
-	-	RSA Private Key	4bef209	Task_1/cert/client/col_one.key	View secret
-	-	RSA Private Key	4bef209	Task_1/cert/client/col_two.key	View secret
-	-	RSA Private Key	4bef209	Task_1/cert/server/agg_in-ota-232347.ads.iu.edu.key	View secret
-	-	RSA Private Key	4bef209	Task_1/cert/ca/signing-ca/private/signing-ca.key	View secret
-	-	RSA Private Key	4bef209	Task_1/cert/ca/root-ca/private/root-ca.key	View secret

🛠 Guidelines to remediate hardcoded secrets

1. Understand the implications of revoking this secret by investigating where it is used in your code.
2. Replace and store your secrets safely. Learn here the best practices.
3. Revoke and rotate these secrets.
4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

• following these best practices for managing and storing secrets including API keys and other credentials
• install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

---

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

[sarthakpati]

@psfoley do you see any major changes preventing us from merging this ASAP?

[psfoley]

@psfoley do you see any major changes preventing us from merging this ASAP?

@sarthakpati Nope - I would expect this can be merged without issue.

[sarthakpati]

@psfoley do you see any major changes preventing us from merging this ASAP?

@sarthakpati Nope - I would expect this can be merged without issue.

Cool, thanks for the confirmation.

@Linardos: thank you once again for the herculean effort that you and @kta-intel have put together to modernize this codebase. Once you fix the comments that I have, I can start putting together some CI/CD stuff to make our lives much easier.

[Linardos]

@sarthakpati I addressed your comments. You may merge. Note that a version of generate_predictions for classification (i.e. inference for classification) still needs work to function though. I can do a separate PR for that when I have it

[sarthakpati]

There are some unresolved conversations, and I am unable to merge until they are resolved. Also, does this PR contain #198 as well?

[Linardos]

Seems #198 is an outdated part of the PR that I have since then removed because csv files are generated on-the-go. I resolved the conversations. I also made the code default to segmentation which is functional through both training and inference. Classification will still need some work in terms of inferring the metrics, but we can do that in a later PR.

[sarthakpati]

Hey @Linardos, apologies for the late review (as you know, I have been swamped). Anyway, great work on all the changes. I am requesting a few minor points of consideration before we can merge this to be used by others. Thanks!

[sarthakpati]

@Linardos since the PR from @kta-intel has been merged (securefederatedai/openfederatedlearning#1141), can you please update the setup appropriately?