commits from bitcoin/master#309
Merged
Merged
Conversation
Add rpcauth-test (introduced #13056) to AC_CONFIG_LINKS, like the other directly called python scripts, to fix out-of-tree `make check`.
ConfirmMessage is reused in future tests apart from its single usage here.
Also make all arguments to getAddress required and document args at call sites.
Addresses #12796. When we're unable to add a sending address to the address book because it already exists as a receiving address, display a message indicating as much. This should help avoid confusion about an address supposedly already in the book but which isn't currently visible in the interface.
…ialog Also modifies corresponding QT code to allow for use within test cases.
…saction.py Same reasoning as in 55f89da
The new TxIndexDB class will be used by a future commit in this change set.
The TxIndex will be responsible for building the transaction index concurrently with the main validation thread by implementing ValidationInterface. This does not process blocks concurrently yet.
TxIndex starts up a background thread to get in sync with the block index before blocks are processed through the ValidationInterface.
In order to preserve getrawtransaction RPC behavior, there needs to be a way for a thread to ensure the transaction index is in sync with the current state of the blockchain.
Now that the transaction index is updated asynchronously, in order to preserve the current behavior of public interfaces, the code blocks until the transaction index is caught up with the current state of the blockchain.
FeatherCoin
approved these changes
Apr 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
qa: Normalize executable location
bitcoin/bitcoin#13051
[tests] Make rpcauth.py testable and add unit tests
bitcoin/bitcoin#13056
test: add rpcauth-test to AC_CONFIG_LINKS to fix out-of-tree make check
bitcoin/bitcoin#13073
[qt] [tests] Clarify address book error messages, add tests
bitcoin/bitcoin#12830
Tests: don't test against min relay fee information in mining_prioritisetransaction.py
bitcoin/bitcoin#13082
Build txindex in parallel with validation
bitcoin/bitcoin#13033