commits from bitcoin/master#341
Merged
Merged
Conversation
…grep specific regexp handling
Add a `createwallet` RPC to allow wallets to be created dynamically at runtime. This functionality is currently only available through RPC and newly created wallets will not be displayed in the GUI.
The node will often disconnect before sending a reject code. A more robust solution would be to read from the debug log.
docs: Linked to the 'Building on FreeBSD' section of the Unix guide where it lists BSD specific guides. Created a FreeBSD build guide (doc/build-freebsd.md). Added in warning about the version of 'gdb' installed by default. Removed the FreeBSD build instructions now that they have their own guide (doc/build-freebsd.md). Updated the sentence to refer to the BSD guides in the 'doc' directory for more specific BSD build instructions. Minor grammatical fix.
…exical_cast<double>(...)
Updating the input explicitly requires the caller to present a mutable input, which more clearly communicates the effects and intent of the method. In most cases, this input is already immediately available and need not be looked up.
This removes the need to include rpc/blockchain.cpp in order to put GetDifficulty under test. GetDifficulty was called in two ways: * with a guaranteed non-null blockindex * with no argument Change the latter case to be provided chainActive.Tip() explicitly.
FeatherCoin
approved these changes
Jun 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix "gmake check" under OpenBSD 6.3 (probably *BSD): Avoid using GNU grep specific regexp handling
bitcoin/bitcoin#13355
[wallet]
createwalletRPC - create new wallet at runtimebitcoin/bitcoin#13058
qa: Fixup setting of PATH env var
bitcoin/bitcoin#13353
qa: Avoid checking reject code for now
bitcoin/bitcoin#13352
doc: split FreeBSD build instructions out of build-unix.md
bitcoin/bitcoin#13372
bench: Use non-throwing ParseDouble(...) instead of throwing boost::lexical_cast(...)
bitcoin/bitcoin#13383
Specialized double-SHA256 with 64 byte inputs with SSE4.1 and AVX2
bitcoin/bitcoin#13191
Docs: Rename “OS X” to the newer “macOS” convention
bitcoin/bitcoin#13366
build: Guard against accidental introduction of new Boost dependencies
bitcoin/bitcoin#13385
wallet: Prevent segfault when sending to unspendable witness
bitcoin/bitcoin#13351
refactoring: Drop UpdateTransaction in favor of UpdateInput
bitcoin/bitcoin#13269
qa: Increase includeconf test coverage
bitcoin/bitcoin#13367
rpc: Remove the need to include rpc/blockchain.cpp in order to put
GetDifficultyunder testbitcoin/bitcoin#13288