Conversation
evgenushka
reviewed
Feb 13, 2025
src/main/java/ParserHelper.java
Outdated
| try { | ||
| return Integer.parseInt(value); | ||
| } catch (NumberFormatException e) { | ||
| return null; |
Collaborator
There was a problem hiding this comment.
если здесь не возвращаешь предупреждение о том, что данные не корректны, верни там, где валидацию проводишь
evgenushka
reviewed
Feb 13, 2025
|
|
||
| public Integer parseInteger(String value) { | ||
| try { | ||
| return Integer.parseInt(value); |
Collaborator
There was a problem hiding this comment.
отступы по всему проекту - 4 символа, здесь явно больше, поправим разом по всему проекту, это я к слову
evgenushka
reviewed
Feb 13, 2025
| } | ||
|
|
||
| private <T> void fillArray(Scanner scanner, int size, Main.datatype datatype, ItemRandomizer<T> randomizer) { | ||
| Storage<T> storage = Storage.<T>getInstance(datatype); |
Collaborator
There was a problem hiding this comment.
отлично, ещё один джейн эйрек )
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Объединена логика Parse