Open
Conversation
…айзерах. Исправлен метод generate в рандомайзерах
…омными значениями и вывода массива на экран(частично)
FedorTvor
reviewed
Feb 13, 2025
src/main/java/Main.java
Outdated
| menu.addAction("3", "Вывод массива объектов на экран", print_array_menu); | ||
| menu.addAction("4", "Сортировка массива", null);//TODO | ||
| menu.addAction("5", "Выход", null); | ||
| menu.addAction("5", "Поиск Объекта по значению", sort_menu); |
evgenushka
reviewed
Feb 13, 2025
src/main/java/BinarySearch.java
Outdated
| //TODO throw | ||
| } | ||
| if (list.size()<=0){ | ||
| throw new RuntimeException("No Objects to sort!"); |
Collaborator
There was a problem hiding this comment.
Убрать Эксепшн, оставить только SOUT
evgenushka
reviewed
Feb 13, 2025
src/main/java/Menu.java
Outdated
| public boolean reopen_after_submenu_closes=false; | ||
|
|
||
| public void removeAction(String key){ | ||
| public Menu removeAction(String key){ |
Collaborator
There was a problem hiding this comment.
Лучше оставить void idea ругается на превышение полномочий в части использования памяти
evgenushka
reviewed
Feb 13, 2025
| @@ -0,0 +1,5 @@ | |||
| class AuthorOfBook extends ValueGetter<Book, java.lang.String>{ | |||
| public java.lang.String get(Book book){ | |||
| return book.getAuthor(); | |||
Collaborator
There was a problem hiding this comment.
Ваня, у нас в самих классах Book, Car и т.п. есть get и set методы, ты зачем-то создаешь им дублеры
И ладно бы дублёры - на каждое поле отдельный класс. Это антипаттерн, имхо..
Collaborator
Author
There was a problem hiding this comment.
Да, там есть сеттеры и геттеры, но их не досатать из дженериков
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.