Open
Conversation
This will make it possible to call it from multiple modules with no code repetition and no need to expose the stdio API.
This way we do not need to expose the stdio API to the wrappers.
We will need this once we split the wrappers into its own module.
This avoids polluting the module with system includes that can affect how the wrapping function declarations are done, via remapping or aliases that are outside our control. This fixes building the project with LFS and time64 support enable. Fixes: Feh#54
This makes the project LFS and time64 aware so that it will internally call the large APIs, and avoid failing due to files with large inode numbers, or stat structures with large time values for example. Fixes: Feh#26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR shuffles things around so that the function wrappers are isolated into their own module, to avoid being affected by the system stdio API declarations from the header. This way we can build with LFS and time64 support with no interference.
The test suite seems to pass, but I've not done further checks. It fixes the build failures seen in Debian, after its transition to enable LFS and time64 by default.