Skip to content

docs(ci): enable localStorage in Node.js 25 to avoid build error #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rvagg merged 1 commit into from
Oct 21, 2025
Merged

docs(ci): enable localStorage in Node.js 25 to avoid build error #329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion docs/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,7 @@ pnpm-debug.log*
# macOS-specific files
.DS_Store
src/content/docs/api
.wrangler/
.wrangler/

# Node.js v25 localStorage file
.astro-localstorage.json
2 changes: 1 addition & 1 deletion docs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"private": true,
"scripts": {
"dev": "astro dev",
"build": "astro build",
"build": "NODE_OPTIONS=\"--localstorage-file=.astro-localstorage.json\" astro build",
Copy link
Contributor

@wjmelements wjmelements Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the default?

Copy link
Contributor

@wjmelements wjmelements Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems the default is no local storage

Copy link
Collaborator Author

@rvagg rvagg Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah .. we don't actually want local storage, none of this is useful, it's all just a fault in @typescript/vfs that will eventually be ironed out

"preview": "astro preview",
"astro": "astro"
},
Expand Down