Merged
Conversation
Benchmark ComparisonBenchmarking comparison between this Pull Request and the comitted values at benchmarks/results thumbnail summary:
better: 1, geomean: 1.148
total diff: 1
No Slower results for the provided threshold = 10% and noise filter = 0.3ns.
| Faster | base/diff | Base Median (ns) | Diff Median (ns) | Modality|
| --------------------------------------------------------- | ---------:| ----------------:| ----------------:| -------- |
| FileOnQ.Imaging.Heif.Benchmarks.Thumbnail.Thumbnail_Write | 1.15 | 60288300.00 | 52499750.00 | several?|
No file given
primary No differences found between the benchmark results with threshold 10%.
Benchmark Resultsthumbnail
BenchmarkDotNet=v0.13.0, OS=Windows 10.0.17763.2114 (1809/October2018Update/Redstone5)
Intel Xeon CPU E5-2673 v4 2.30GHz, 1 CPU, 2 logical and 2 physical cores
.NET SDK=5.0.400
[Host] : .NET 5.0.9 (5.0.921.35908), X64 RyuJIT
Job-FJVQTT : .NET 5.0.9 (5.0.921.35908), X64 RyuJIT
Runtime=.NET 5.0 InvocationCount=1 LaunchCount=1
UnrollFactor=1
primary
BenchmarkDotNet=v0.13.0, OS=Windows 10.0.17763.2114 (1809/October2018Update/Redstone5)
Intel Xeon CPU E5-2673 v4 2.30GHz, 1 CPU, 2 logical and 2 physical cores
.NET SDK=5.0.400
[Host] : .NET 5.0.9 (5.0.921.35908), X64 RyuJIT
Job-UAQZJA : .NET 5.0.9 (5.0.921.35908), X64 RyuJIT
Runtime=.NET 5.0 InvocationCount=1 LaunchCount=1
UnrollFactor=1
|
Contributor
Author
|
This PR requires new benchmark results to be uploaded prior to merging. I added a new checklist item to the PR description |
SkyeHoefling
commented
Sep 8, 2021
SkyeHoefling
commented
Sep 8, 2021
SkyeHoefling
commented
Sep 8, 2021
SkyeHoefling
commented
Sep 8, 2021
Contributor
Author
|
I just looked through the code changes and it appears there is issues with tabs in several areas of the code. There are extra tabs or not enough tabs. I am going to do another pass and push changes |
SkyeHoefling
commented
Sep 8, 2021
tests/FileOnQ.Imaging.Heif.Tests/Integration/PrimaryImage_ToStream_Tests.cs
Outdated
Show resolved
Hide resolved
SkyeHoefling
commented
Sep 8, 2021
tests/FileOnQ.Imaging.Heif.Tests/Integration/Thumbnail_ToStream_Tests.cs
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@mitchelsellers I think this PR is good, can you take a look and see if I missed any typos or anything. If you think it is good to go please merge it. I did not add XML docs to this PR as we are going to do all XML docs in #22 for the 1.0.0 release |
mitchelsellers
approved these changes
Sep 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #9
Description
Adds new Memory Buffer APIs, unit tests and benchmarks
IImage - New APIs
Merge Checklist