Adding .net 4.8 and .net 5 win form apps for testing.#44
Conversation
Benchmark ComparisonBenchmarking comparison between this Pull Request and the comitted values at benchmarks/results thumbnail
Welcome to .NET 5.0!
---------------------
SDK Version: 5.0.404
Telemetry
---------
The .NET tools collect usage data in order to help us improve your experience. It is collected by Microsoft and shared with the community. You can opt-out of telemetry by setting the DOTNET_CLI_TELEMETRY_OPTOUT environment variable to '1' or 'true' using your favorite shell.
Read more about .NET CLI Tools telemetry: https://aka.ms/dotnet-cli-telemetry
----------------
Installed an ASP.NET Core HTTPS development certificate.
To trust the certificate run 'dotnet dev-certs https --trust' (Windows and macOS only).
Learn about HTTPS: https://aka.ms/dotnet-https
----------------
Write your first app: https://aka.ms/dotnet-hello-world
Find out what's new: https://aka.ms/dotnet-whats-new
Explore documentation: https://aka.ms/dotnet-docs
Report issues and find source on GitHub: https://github.com/dotnet/core
Use 'dotnet --help' to see available commands or visit: https://aka.ms/dotnet-cli
--------------------------------------------------------------------------------------
summary:
worse: 4, geomean: 1.250
total diff: 4
| Slower | diff/base | Base Median (ns) | Diff Median (ns) | Modality|
| ------------------------------------------------------------ | ---------:| ----------------:| ----------------:| -------- |
| FileOnQ.Imaging.Heif.Benchmarks.Thumbnail.Thumbnail_ToStream | 1.31 | 47627000.00 | 62426750.00 | |
| FileOnQ.Imaging.Heif.Benchmarks.Thumbnail.Thumbnail_ToArray | 1.29 | 47949500.00 | 61713850.00 | |
| FileOnQ.Imaging.Heif.Benchmarks.Thumbnail.Thumbnail_ToSpan | 1.21 | 49832700.00 | 60379200.00 | |
| FileOnQ.Imaging.Heif.Benchmarks.Thumbnail.Thumbnail_Write | 1.19 | 52499750.00 | 62623700.00 | several?|
No Faster results for the provided threshold = 10% and noise filter = 0.3ns.
No file given
primary summary:
better: 2, geomean: 1.177
total diff: 2
No Slower results for the provided threshold = 10% and noise filter = 0.3ns.
| Faster | base/diff | Base Median (ns) | Diff Median (ns) | Modality|
| ------------------------------------------------------------------ | ---------:| ----------------:| ----------------:| --------:|
| FileOnQ.Imaging.Heif.Benchmarks.PrimaryImage.PrimaryImage_ToArray | 1.22 | 2880173350.00 | 2357581500.00 | |
| FileOnQ.Imaging.Heif.Benchmarks.PrimaryImage.PrimaryImage_ToStream | 1.13 | 2719733500.00 | 2398107100.00 | |
No file given
Benchmark Resultsthumbnail
BenchmarkDotNet=v0.13.0, OS=Windows 10.0.17763.2366 (1809/October2018Update/Redstone5)
Intel Xeon CPU E5-2673 v4 2.30GHz, 1 CPU, 2 logical and 2 physical cores
.NET SDK=5.0.404
[Host] : .NET 5.0.13 (5.0.1321.56516), X64 RyuJIT
Job-JZMPNE : .NET 5.0.13 (5.0.1321.56516), X64 RyuJIT
Runtime=.NET 5.0 InvocationCount=1 LaunchCount=1
UnrollFactor=1
primary
BenchmarkDotNet=v0.13.0, OS=Windows 10.0.17763.2366 (1809/October2018Update/Redstone5)
Intel Xeon Platinum 8272CL CPU 2.60GHz, 1 CPU, 2 logical and 2 physical cores
.NET SDK=5.0.404
[Host] : .NET 5.0.13 (5.0.1321.56516), X64 RyuJIT
Job-TQEXEA : .NET 5.0.13 (5.0.1321.56516), X64 RyuJIT
Runtime=.NET 5.0 InvocationCount=1 LaunchCount=1
UnrollFactor=1
|
SkyeHoefling
left a comment
There was a problem hiding this comment.
Thanks for the contribution, this looks really good. There are some issues images resizing correctly on smaller devices. Can you update the winforms code to resize the jpeg to fix the window.
Here are some screenshots of using a thumbnail file vs a full file. The thumbnail file is smaller so it loads into the window with no issues:

When I load a larger file it is hard to tell what the image is:

I have
High Efficiency Images.zip
attached my sample files for you to use:
|
@kenny-sellers thanks for making the changes, I just pulled the sample app and things look correct with the larger heic files. See screenshot below |
|
@kenny-sellers I do not see the "Build" folder in the net48 project. Did something not get pushed up or is it not working when you try and add the file as a non-compiled item? See screenshot |
|
@ahoefling check now. VS was doing something strange! |
|
Everything looks good, I updated the net48 project to use new style csproj. I updated the build to compile the winforms apps under x86, x64, and anycpu so we always have something that compiles. If the build succeeds we should be ready to merge this |
… at once; this should decrease build times
|
@ahoefling Looks like the build is fixed now! |
|
Everything looks good to me, let's merge this. Thanks for the contribution |


Fixes: #38
Description
Added two WinForms Applications for testing purposes; targeting .NET 4.8 and .NET 5.
Each of them have provide the user a dialog to select a file to process.
Merge Checklist