Draw background image instead of color when set #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hey the lib was never meant to handle the background images so I will have to think about this one a bit. Got to play around with it and feel it out. |
Contributor
Author
|
This pull request is mainly grown out of our requirements, which we wanted to contribute back as it may be useful to others. But I certainly get your point. Currently it requires the developer to put in a correctly sized image to look good, there is no automatically scale to fit and this may not be reasonable. Just try it out and think about it :) |
rzimmer
force-pushed
the
feature/background_image
branch
from
273c307 to
64f36d5
Compare
…ground (when set) instead of the background color
rzimmer
force-pushed
the
feature/background_image
branch
from
64f36d5 to
f7a574b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request allows drawing an image in the background instead of just specifying only a background color. A background image takes precedence over a background color.
The background image is not rounded by this pull request, but you may set an RoundedDrawable found in the RoundedImageView library.