Skip to content
This repository was archived by the owner on Sep 21, 2022. It is now read-only.

Conversation

@remybach
Copy link
Contributor

@remybach remybach commented Jul 27, 2018

The subscriptions-action property will automatically hide an element unless you provide a subscriptions-display property that provides rules for when it should display.

@remybach remybach requested a review from apaleslimghost July 27, 2018 09:03
Copy link
Contributor

@liamkeaton liamkeaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small tweak, could this property be put next to the other subscriptions- properties. Will be easier to see what this magic does for future people

Copy link
Contributor

@liamkeaton liamkeaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@remybach
Copy link
Contributor Author

remybach commented Jul 27, 2018

Can't merge this until the following downstream issues are fixed:

sass/node-sass#2355 which further depends on nodejs/node-gyp#1471

Edit: temporarily disabled snyk.

@remybach remybach merged commit 5ca001f into master Jul 27, 2018
@remybach remybach deleted the rb-fix-sign-in-links branch July 27, 2018 11:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants