Add support through python3.14. Move to pyproject.toml. Fix deprecated locale function.#3
Open
brandonschabell wants to merge 1 commit intoFindDefinition:masterfrom
Open
Conversation
…d locale function.
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the package configuration by migrating from a legacy setup.py to the modern pyproject.toml standard, fixing a deprecated locale API call, and updating Python version support.
- Migrated package metadata and dependencies from setup.py to pyproject.toml (PEP 621 compliance)
- Replaced deprecated
locale.getdefaultlocale()withlocale.getlocale()and added exception handling - Added Python 3.11-3.14 support in documentation and CI workflows
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| setup.py | Simplified to minimal custom commands; moved metadata to pyproject.toml |
| pyproject.toml | Added comprehensive project metadata, dependencies, and dynamic version configuration |
| ccimport/buildtools/writer.py | Fixed deprecated locale API call with exception handling |
| ccimport/init.py | Added version import with fallback and all definition |
| test/test_source_iter.py | Changed return statement to assertion (test fix) |
| README.md | Updated Python version support documentation to 3.6-3.14 |
| .github/workflows/build.yaml | Added Python 3.11-3.14 to CI test matrix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating a PR to address a few issues: