Fixes bug where -jar and -cp were conflicting and breaking stagegroups#216
Merged
Merged
Conversation
laserval
pushed a commit
that referenced
this pull request
Jun 14, 2013
Fixes bug where -jar and -cp were conflicting and breaking stagegroups
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When StageGroups contain stages from multiple jars, the java commandline call was being incorrectly constructed.
java -cp <path>/* -jar <onejar>.jarwas incorrect.-jarwill force the java command to ignore any passed classpath with the-cpflag. Additionally, wildcard classpaths would only work if there was no classpath at all in the manifest of any of the jars, otherwise it would crash.In short, I think we (me) rather failed in testing StageGroups when they were not living in the same jar.