Fix pandas 2.0 incompatibility and parameterize load_biome_herarchy_dict#10
Open
bleedblack1 wants to merge 1 commit intoFinn-Lab:masterfrom
Open
Fix pandas 2.0 incompatibility and parameterize load_biome_herarchy_dict#10bleedblack1 wants to merge 1 commit intoFinn-Lab:masterfrom
bleedblack1 wants to merge 1 commit intoFinn-Lab:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues in utils.py.
Problem:
Series.iteritems()was removed in pandas 2.0, causing an AttributeError.Fix:
Replaced
Series.iteritems()withSeries.items()insplit_tt().Additional improvement:
Replaced
type(lin) == strwithisinstance(lin, str)insplit_tt()andi_T().load_biome_herarchy_dict()Problem:
load_biome_herarchy_dict()always resolved the biome hierarchy file throughTaxonomyToVectorParams even when called from other components.
Because the function used an LRU cache, the resolved path was shared across
callers regardless of the pipeline.
Fix:
Added optional parameters:
model_namemodel_versionThese allow callers to explicitly specify the model repository while keeping
backward-compatible defaults.
resolved issue: #7 #9