-
Notifications
You must be signed in to change notification settings - Fork 222
Adding '--force' argument #424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…e your bill, such as minimum instances required.
PatrickJODonnell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@mbleigh @jamesdaniels @paulb777 much needed addition! |
|
can someone approve this, thanks |
|
PLEASE APPROVE THIS!!!!!! |
|
please approve this. |
Co-authored-by: Bryan Kendall <bryan.a.kendall@gmail.com>
…port for channel site deployment with force flag. Updated tests to and types to account for force flags. Force flag is now optional on ProductionDeployConfig and ChannelDeployConfig. Simplified deploy calls using force flag to automatically append force based on the boolean value nad removed the force-specific branch in index.ts
|
Alright, sorry for the churn, but it turns out that the tests on main have been broken a while. I've updated
(oh, and of course, |
bkendall
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last bit, but everything looks good.
jhuleatt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ThadCastl3!
|
I'll work on releasing this on Monday since we don't typically release on Fridays. Thanks for the work @ThadCastl3 |
|
I noticed we didn't update the readme but could just throw this in:
Bypass the confirmation prompt.` |

This pull request introduces a new
--forceflag for Firebase deployments, enabling users to force deploy changes that may increase their billing, such as deploying more than 0 minimum instances of a function. The changes include updates to the deployment logic, input handling, and test coverage.Reasoning:
Enhancements to Deployment Functionality:
forceinput inaction.ymlto accept the--forceflag for deployments. This input is optional and defaults tofalse.deployWithForcefunction insrc/deploy.tsto handle deployments with the--forceflag, including parsing its result.deployPreviewanddeployProductionSite) to support theforceoption in their configurations. [1] [2]Codebase Updates for
--forceSupport:execWithCredentialsinsrc/deploy.tsto append the--forceflag to Firebase CLI commands when theforceoption is enabled. [1] [2]src/index.tsto retrieve theforceinput, pass it to deployment functions, and handle deployments with theforceflag if specified. [1] [2] [3]Test Coverage Improvements:
test/deploy.test.tsto validate that the--forceflag is correctly included in deployment commands when enabled.forceDeploySingleSiteSuccesssample intest/samples/cliOutputs.tsto simulate successful deployments with the--forceflag.Documentation and Cleanup:
action.ymlinto single-line format for better readability.updated for Google CLA