Firestore: using properties which names containing special characters as path parts

[merlinnot]

Regexp currently used for matching parts (/\{[a-z0-9_]+\}/gi) of the path which should be bound to element's properties does not match some special cases like property_$. I'd expect this regexp to match all valid property names.

[tjmonsi]

Can you expound on this or give a specific scenario? (like a simple firestore structure and specific scenario that would need to use property_$

[merlinnot]

This won't work:

static get properties() {
  return {
    uid$: {
      type: String,
      value: 'mBylIa6HUTUU5e4npnoE',
    },
    user: {
      type: Object,
      doc: 'users/{uid$}',
    }
  }
}

while this will:

static get properties() {
  return {
    uid: {
      type: String,
      value: 'mBylIa6HUTUU5e4npnoE',
    },
    user: {
      type: Object,
      doc: 'users/{uid}',
    }
  }
}

Personally, I don't name properties like this, but since it is perfectly valid, we should support it. I'll make a PR for this.

[tjmonsi]

I see. Thanks

[ronnievsmith]

Does this apply / help? https://firebase.google.com/docs/firestore/quotas

[tjmonsi]

@rhroyston what do you mean does this apply?

[ronnievsmith]

I meant the section in the link saying

Constraints on field names

[merlinnot]

It does not apply to the scope of this PR. It fixed usage of some weird property names as Polymer properties, it has nothing to do with the Firestore itself.

Firestore paths and field names are not validated by this mixin nor they will be since it's being done by the library / backend already.

[ronnievsmith]

got it ok

…

On Fri, Jan 5, 2018 at 2:15 AM, Natan Sągol ***@***.***> wrote: It does not apply to the scope of this PR. It fixed usage of some weird property names as Polymer properties, it has nothing to do with the Firestore itself. Firestore paths and field names are not validated by this mixin nor they will be since it's being done by the library / backend already. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#289 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AMKS-2KVd4wHYhDBYvyigWsT1J-0F-pcks5tHdomgaJpZM4QAxvO> .

-- - Ron Royston (318) 560-0145 https://rack.pub

[merlinnot]

Closing due to inactivity.