added an "exists" attribute to differentiate whether we have data or not#177
added an "exists" attribute to differentiate whether we have data or not#177christophe-g wants to merge 7 commits intoFirebaseExtended:masterfrom
Conversation
| this.async(function() { | ||
| this.syncToMemory(function() { | ||
| this.splice('data', this.__indexFromKey(key), 1); | ||
| if (this.data.length === 0) { |
There was a problem hiding this comment.
Doesn't this imply the data in memory does not reflect what is in Firebase?
If that is the case then this isn't helpfully in the case of [] which could very well exist in either location and be valid.
There was a problem hiding this comment.
Thanks,
http://stackoverflow.com/questions/15408416/how-to-handle-empty-arrays-in-firebase : "there is no way to force empty array into firebase".
And yes, data in memory does not always reflect what is in Firebase - see discussion #177 (zeroValue).
|
Would you consider adding a |
… now readonly reflect to attribute
|
Landed |
e8ee73b to
4cb63cb
Compare
|
Any update on merging |
|
Seems the codebase diverted quite a bit and this PR would need to be rebased against master. I'll do that once #213 is merged. |
|
Closed by #234 |
follows discussions #33.