This repository was archived by the owner on May 19, 2025. It is now read-only.
from polymer to Polymer in 2.0-preview#204
Merged
tjmonsi merged 28 commits intoFirebaseExtended:2.0-previewfrom Feb 21, 2018
Merged
from polymer to Polymer in 2.0-preview#204tjmonsi merged 28 commits intoFirebaseExtended:2.0-previewfrom
tjmonsi merged 28 commits intoFirebaseExtended:2.0-previewfrom
Conversation
With the new order of element intialization (bottom-up), the firebase-app element is typically the last one to be initialized. This means that Polymerfire elements need to await app initialization in order to successfully create app instances for themselves.
This reverts commit bfebfe3.
Committed with correct e-mail address
bartolom
changed the title
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request wants to make this Polymer element consistent with the majority of other Polymer elements in the 2.0-preview branch. The uppercase version "Polymer" and "PolymerLabs" are closer to real name of the github project name, like presented in the git URL.
The use of mixed case does not seem to have an effect on bower and JavaScript projects. But other languages like Java are more picky and would benefit from consistency.
I fixed this in the "2.0-preview" branch of this element, because it would be very nice to have this cleaned up and consistent in 2.0 release. I have manually checked 66 elements that have a "2.0-preview" branch. 56 are ok. This element is one of 10 which has these small differences.
I'm mostly concerned with the bower "Main" dependencies, but as I have changed this file already I also fixed this in the devDependencies
This pull request is a manual follow up of PolymerLabs/tedium#47 and PolymerLabs/tedium#48 which try to do this in an automated way, but are stuck.