fix firebase query returns 2 sets for #263

[tjmonsi]

Fixing #263

I saw that the __queryChanged is being called thrice, making creation of event listeners called thrice. Currently wrapped them in a checker if both query and oldQuery exists with this idea

1. __queryChanged is called in the attached phased
2. __queryChanged is called when any time a new query is created on calculated in the __computeQuery

Can anyone give me some feedback on any bugs I missed?

Thanks

[christophe-g]

@tjmonsi - thanks a lot for this - I 'll try to test it over during the we!

[tjmonsi]

@christophe-g give me a heads-up when you're done. Thanks :)

[tbeattysk]

Using this commit I'm consistently getting duplicates.
I agree with the idea of getting rid of "on-value", any idea why it was used in the first place?

I don't have time to explore your code, but here is the test case I was using: https://github.com/tbeattysk/firebase-duplicate-test

[tjmonsi]

@tbeattysk did you manage to use my branch for your test case?

[tjmonsi]

@tbeattysk I used your repo as a test case using a fix that I added. It's working now (I think).

As for using on-value: see merged PR: #230

[andrewspy]

@tjmonsi I have tested the latest commit (80ee04a), and it's still not working 100% correctly based on my test case #263 (comment). Now I don't get the duplicated result, but if you click the "Add query" fast enough, you'll get empty query result on the first few query before the result is "eventually" return in subsequent query.

I also have another <firebase-query> in my project, which doesn't return any expected result at all.

[tjmonsi]

I think the original idea of using on instead of once for the value event was a good take. Because the once event is not being called. I don't know why the promise is not being resolved. I think I would try to create a simple repo for it and file a bug in firebase for it.

[tjmonsi]

@andrewspy can you check it again?

[andrewspy]

@tjmonsi I am happy to report that it is finally working on both my test case and my project.

Thanks!

[tjmonsi]

@christophe-g any report?

[christophe-g]

@tjmonsi - looks good! thanks and sorry for the delay (... quite busy ...)

[FluorescentHallucinogen]

@tjmonsi Please release the new version 2.2.1.

[tjmonsi]

@FluorescentHallucinogen just released 2.2.1... sorry for the delay