Skip to content
This repository was archived by the owner on May 19, 2025. It is now read-only.

Update README.md#277

Merged
tjmonsi merged 1 commit intoFirebaseExtended:masterfrom
imarian97:patch-1
Oct 7, 2017
Merged

Update README.md#277
tjmonsi merged 1 commit intoFirebaseExtended:masterfrom
imarian97:patch-1

Conversation

@imarian97
Copy link
Copy Markdown
Contributor

Add project-id in the example firebase-app to be able to use firebase.firestore(). Implementation for projectId already merged in #273

Add project-id in the example firebase-app to be able to use firebase.firestore(). Implementation for projectId already merged in  #273
@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@imarian97
Copy link
Copy Markdown
Contributor Author

I signed it!

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

@tjmonsi tjmonsi merged commit 15f1c8a into FirebaseExtended:master Oct 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants