This repository was archived by the owner on May 19, 2025. It is now read-only.
Fix query in FirestoreMixin.#297
Merged
tjmonsi merged 1 commit intoFirebaseExtended:firestorefrom Oct 25, 2017
Merged
Conversation
Fixes an issue with `query` parameter being read from the constructor of an element instead of collecting the correct one from the prototype chain in FirestoreMixin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue with
queryparameter being read from the constructor of an element instead of collecting the correct one from the prototype chain in FirestoreMixin.Fixes #296