This repository was archived by the owner on May 19, 2025. It is now read-only.
FirestoreMixin: ensure that it was not previously applied to the same class.#301
Closed
merlinnot wants to merge 3 commits intoFirebaseExtended:firestorefrom
Closed
FirestoreMixin: ensure that it was not previously applied to the same class.#301merlinnot wants to merge 3 commits intoFirebaseExtended:firestorefrom
merlinnot wants to merge 3 commits intoFirebaseExtended:firestorefrom
Conversation
Contributor
|
I know a use case that can happen but I don't know if this is necessary. Can you give me a working example that has a possible race condition? I don't think a mixin applied twice will call a method twice. |
Contributor
Author
|
Now it's just a performance improvement. |
merlinnot
force-pushed
the
fix-issue-300
branch
from
d9a3fe4 to
fd12a0d
Compare
Contributor
Author
|
Closing in favor of #310 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #300