This repository was archived by the owner on May 19, 2025. It is now read-only.
Add query property to _firestoreProps in FirestoreMixin.#303
Closed
merlinnot wants to merge 3 commits intoFirebaseExtended:firestorefrom
Closed
Add query property to _firestoreProps in FirestoreMixin.#303merlinnot wants to merge 3 commits intoFirebaseExtended:firestorefrom
merlinnot wants to merge 3 commits intoFirebaseExtended:firestorefrom
Conversation
This change fixes an issue which occurs when observed/bound properties are defined prior to a call of `connectedCallback`. Since _firestoreUpdateBinding method handles null and undefined values correctly, the `if` statement can be safely removed.
merlinnot
force-pushed
the
fix-issue-302
branch
from
b84749f to
5982940
Compare
danbaechtold
suggested changes
Nov 26, 2017
danbaechtold
left a comment
danbaechtold
left a comment
There was a problem hiding this comment.
There is a bug on line 168, here is the fix:
this._firestoreUpdateBinding(name, config);
Tested with the official demo:
/bower_components/polymerfire/demo/firebase-firestore.html
Now the demo works (query will now sort the collection). Thanks a a lot!
Contributor
Author
|
@danbaechtold I’ve fixed that in #310, thank you. Closing in favor of #310 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #302