Changes to codegen to make R6 satellites compile#62
Merged
andrzejskowronski merged 5 commits intomainfrom Jun 23, 2025
Merged
Conversation
# Conflicts: # src/fhir-codegen/Properties/launchSettings.json
andrzejskowronski
approved these changes
Jun 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although we had added support for R6, we never actually made it compile. The changes in this PR make sure the compiled code actually is useable.
One of the corrections to make was add an "explcit name" for some of the new backbone components in R6. This turned out to be a bit harder than hoped for, since the code for using explicit names had been duplicated. So I took the effort to deduplicate - all code pertaining to defining explicit names is now in one function.