Skip to content

fix(ci): Don't render config in Dockerfile #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rolodato merged 1 commit into from
Apr 8, 2025
Merged

fix(ci): Don't render config in Dockerfile #155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM python:3.12-slim as application
FROM python:3.12-slim AS application

WORKDIR /app

Expand All @@ -10,7 +10,6 @@ ENV PATH="$VIRTUAL_ENV/bin:$PATH"
COPY src /app/src
COPY requirements.lock pyproject.toml /app/
RUN pip install --no-cache-dir -r requirements.lock
RUN edge-proxy-render-config

EXPOSE 8000

Expand Down
8 changes: 7 additions & 1 deletion src/edge_proxy/settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,13 @@ def json_config_settings_source() -> dict[str, Any]:
at the project's root.
"""
encoding = "utf-8"
return json.loads(Path(CONFIG_PATH).read_text(encoding))
try:
config = json.loads(Path(CONFIG_PATH).read_text(encoding))
logger.info(f"Loaded configuration from {CONFIG_PATH}")
return config
except FileNotFoundError:
logger.info(f"Configuration file at {CONFIG_PATH} not found")
return {}


class EnvironmentKeyPair(BaseModel):
Expand Down