Conversation
- Add `last_run_finished_at` admin field - Add `unlock` admin action
| def last_run_finished_at(self, instance: RecurringTask) -> datetime | None: | ||
| if last_run := instance.task_runs.order_by("-started_at").first(): | ||
| return last_run.finished_at | ||
| return None |
There was a problem hiding this comment.
What's the intention here? To add this to the list view, or just the detail view? At the moment, I'm not sure it's added to either? 🤔
There was a problem hiding this comment.
I'd also be reluctant to add this to the list display as it probably won't perform that well being run for all the records in the view.
There was a problem hiding this comment.
Good catch, added the field to list_display.
I'd also be reluctant to add this to the list display as it probably won't perform that well being run for all the records in the view.
A similiar query is already run for all the records in the view — see last_run_status. I wouldn't worry too much about performance as the recurring task list is fairly constant.
There was a problem hiding this comment.
Yeah, fair enough. I guess there's an argument to say that we could cache the last run between the 2 methods here, but maybe that's over optimisation at this stage.
| def last_run_finished_at(self, instance: RecurringTask) -> datetime | None: | ||
| if last_run := instance.task_runs.order_by("-started_at").first(): | ||
| return last_run.finished_at | ||
| return None |
There was a problem hiding this comment.
Yeah, fair enough. I guess there's an argument to say that we could cache the last run between the 2 methods here, but maybe that's over optimisation at this stage.
2 participants
This PR adds a way to bulk unlock recurring tasks from the Django admin.
Additionally, it surfaces the last run time, which helps to determine whether a given recurring task is stuck or not.