This repository was archived by the owner on Mar 28, 2025. It is now read-only.

fix(17): Add timeout to auto unlock recurring tasks #16

Merged

gagantrivedi merged 3 commits intomainfrom

fix/locked-tasks

Jan 14, 2025

Member

gagantrivedi commented Jan 6, 2025 •

edited

Loading

Fixes #17 by picking up locked tasks for processing after a timeout.

gagantrivedi force-pushed the fix/locked-tasks branch 3 times, most recently from 28e82e6 to dc63661 Compare

January 6, 2025 08:13

gagantrivedi commented

View reviewed changes

task_processor/decorators.py

gagantrivedi commented

View reviewed changes

task_processor/migrations/0012_add_locked_at_and_timeout.py

gagantrivedi force-pushed the fix/locked-tasks branch from dc63661 to cba7ead Compare

January 6, 2025 08:39

gagantrivedi commented

View reviewed changes

task_processor/decorators.py

gagantrivedi force-pushed the fix/locked-tasks branch from cba7ead to f0ac380 Compare

January 6, 2025 08:43

gagantrivedi changed the title ~~fix(locked-tasks): wip~~ fix(17/recurring-task-lock): Add timeout to auto unlock task

gagantrivedi linked an issue

that may be closed by this pull request

Recurring Tasks can get stuck in locked status #17

Closed

gagantrivedi commented

View reviewed changes

task_processor/migrations/sql/0012_get_recurringtasks_to_process.sql Outdated

gagantrivedi commented

View reviewed changes

task_processor/processor.py

gagantrivedi force-pushed the fix/locked-tasks branch 2 times, most recently from dfd51cd to 6e07161 Compare

January 6, 2025 08:55


          fix(17/recurring-task-lock): Add timeout to auto unlock task

6e07161

gagantrivedi marked this pull request as ready for review

January 6, 2025 10:14

gagantrivedi requested review from a team and matthewelwell and removed request for a team

January 6, 2025 10:14

matthewelwell reviewed

View reviewed changes

Contributor

matthewelwell left a comment •

edited

Loading

Added a few fairly minor comments / questions, but overall this looks excellent 👌

task_processor/models.py Outdated

task_processor/migrations/0012_add_locked_at_and_timeout.py Outdated

task_processor/migrations/sql/0012_get_recurringtasks_to_process.sql Outdated

tests/unit/task_processor/test_unit_task_processor_processor.py

tests/unit/task_processor/test_unit_task_processor_processor.py Outdated

gagantrivedi force-pushed the fix/locked-tasks branch from ed052fa to d8a4c37 Compare

January 8, 2025 04:23

gagantrivedi changed the title ~~fix(17/recurring-task-lock): Add timeout to auto unlock task~~ fix(locked_tasks): Add timeout to auto unlock tasks


          fix locks for non recurring tasks

d8a4c37

gagantrivedi requested a review from matthewelwell

January 8, 2025 04:26

matthewelwell approved these changes

View reviewed changes

tests/unit/task_processor/test_unit_task_processor_processor.py Outdated

task_processor/migrations/sql/0012_get_tasks_to_process.sql Outdated

task_processor/migrations/sql/0012_get_recurringtasks_to_process.sql


          remove auto unlock from tasks

64fa4e7

gagantrivedi commented

View reviewed changes

task_processor/migrations/0012_add_locked_at_and_timeout.py

gagantrivedi changed the title ~~fix(locked_tasks): Add timeout to auto unlock tasks~~ fix(17): Add timeout to auto unlock recurring tasks

gagantrivedi requested a review from matthewelwell

January 10, 2025 10:52

matthewelwell approved these changes

View reviewed changes

gagantrivedi merged commit 4722bf1 into main

gagantrivedi mentioned this pull request

deps: bump task-processor Flagsmith/flagsmith#4995

Merged

4 tasks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet