Skip to content

Editing an approved Change Request does not invalidate approval #7056

@adamvialpando

Description

@adamvialpando

How are you running Flagsmith

  • Self Hosted with Docker
  • Self Hosted with Kubernetes
  • SaaS at flagsmith.com
  • Some other way (add details in description below)

Describe the bug

When a change request has been approved the creator can edit the change request and still publish it without re-requesting approval. Editing an approved change request should invalidate the existing approval and require re-approval before publishing.

Steps To Reproduce

  1. Create a change request
  2. Have a colleague approve it
  3. Edit the change request after approval
  4. Observe that the Publish action is still available without re-approval
  5. Publishing succeeds despite the post-approval edit

Expected behavior

It should not be possible to edit an approved change request (even if it was approved by 1 of N required approvals - the moment it has 1 approval it cannot be edited anymore)

Screenshots

No response

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions