fix: Revert flag-engine v10 revert to re-apply engine upgrade#6741
fix: Revert flag-engine v10 revert to re-apply engine upgrade#6741gagantrivedi merged 2 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Docker builds report
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6741 +/- ##
==========================================
+ Coverage 98.25% 98.26% +0.01%
==========================================
Files 1312 1327 +15
Lines 48568 48877 +309
==========================================
+ Hits 47722 48031 +309
Misses 846 846 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The branch is almost identical to the reverted one. Can I re-ask the reason why we reverted, was it out of safety during the hackaton or because we identified a regression? |
Yeah, it was because the e2e tests that you wrote for Edge, when running against staging, were failing. We later realised that the failure was caused by Core not having access to identity override data, and not because something was wrong with the evaluation engine/logic. |
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Reverts #6674
This PR reverts the flag-engine v10 revert, effectively re-applying the original upgrade from #6653, including:
flagsmith-flag-enginefrom thefix/missing-exportbranch back to^10.0.3flagsmithSDK from^3.10.0back to^5.1.1pydantic-collectionsdependencyutil/engine_models/How did you test this code?