Skip to content

feat(GitLab): Add GitLab to Project Integrations#7239

Open
emyller wants to merge 5 commits intomainfrom
feat/gitlab-integration-credentials
Open

feat(GitLab): Add GitLab to Project Integrations#7239
emyller wants to merge 5 commits intomainfrom
feat/gitlab-integration-credentials

Conversation

@emyller
Copy link
Copy Markdown
Contributor

@emyller emyller commented Apr 14, 2026 •
edited
Loading

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Closes #7159

This introduces GitLab to the Project Integrations tab.

See proposed documentation.

🎉 Bonus: update GitLab logo to their refreshed version.

How did you test this code?

New functional tests. Also screenshots:

image image image image image

@emyller emyller self-assigned this Apr 14, 2026
@emyller emyller requested review from a team as code owners April 14, 2026 20:10
@emyller emyller requested review from khvn26 and kyle-ssg and removed request for a team April 14, 2026 20:10
claude[bot]
claude bot reviewed Apr 14, 2026
View reviewed changes
Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Code review skipped — your organization's overage spend limit has been reached.

Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.

Once credits are available, reopen this pull request to trigger a review.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 14, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Preview Apr 14, 2026 8:16pm
flagsmith-frontend-preview Ignored Ignored Preview Apr 14, 2026 8:16pm
flagsmith-frontend-staging Ignored Ignored Preview Apr 14, 2026 8:16pm

Request Review

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard api Issue related to the REST API labels Apr 14, 2026
@emyller emyller changed the title Feat/gitlab integration credentials feat(GitLab): Add GitLab to Project Integrations Apr 14, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 14, 2026 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-7239 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-7239 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-api-test:pr-7239 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-7239 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-7239 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-7239 Finished ✅ Results ✅

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 14, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.29%. Comparing base (c3c837a) to head (1987f2d).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7239      +/-   ##
==========================================
- Coverage   98.35%   98.29%   -0.07%     
==========================================
  Files        1350     1357       +7     
  Lines       50723    50846     +123     
==========================================
+ Hits        49891    49979      +88     
- Misses        832      867      +35

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 14, 2026 •
edited
Loading

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  51.5 seconds
commit  626f876
info  🔄 Run: #16047 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  48 seconds
commit  626f876
info  🔄 Run: #16047 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  54.3 seconds
commit  626f876
info  🔄 Run: #16047 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  1 minute, 14 seconds
commit  626f876
info  🔄 Run: #16047 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  0.9 seconds
commit  1987f2d
info  🔄 Run: #16048 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  11 passed

Details

stats  11 tests across 8 suites
duration  28.2 seconds
commit  1987f2d
info  🔄 Run: #16048 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  17 passed

Details

stats  17 tests across 14 suites
duration  58.2 seconds
commit  1987f2d
info  🔄 Run: #16048 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  53.6 seconds
commit  1987f2d
info  🔄 Run: #16048 (attempt 1)

@github-actions github-actions bot added the feature New feature or request label Apr 14, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 14, 2026 •
edited
Loading

Visual Regression

16 screenshots compared. See report for details.
View full report

khvn26
khvn26 approved these changes Apr 15, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@khvn26 khvn26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Comment thread api/integrations/gitlab/views.py


class GitLabConfigurationViewSet(ProjectIntegrationBaseViewSet):
serializer_class = GitLabConfigurationSerializer # type: ignore[assignment]
Copy link
Copy Markdown
Member

@khvn26 khvn26 Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: I guess there's nothing to be done here except making ProjectIntegrationBaseViewSet generic (which is I appreciate is way out of scope for this PR).

Comment thread api/tests/unit/integrations/gitlab/test_views.py
Comment on lines +42 to +50
assert log.events == [
{
"event": "gitlab-configuration-created",
"level": "info",
"gitlab_instance_url": "https://gitlab.example.com",
"project_id": project.id,
"organisation_id": project.organisation_id,
},
]
Copy link
Copy Markdown
Member

@khvn26 khvn26 Apr 15, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! nit: maybe use project__id and organisation__id to harness OTel conventions (the processor will convert those to project.id and organisation.id)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@claude claude[bot] claude[bot] left review comments

@khvn26 khvn26 khvn26 approved these changes

@kyle-ssg kyle-ssg Awaiting requested review from kyle-ssg kyle-ssg is a code owner automatically assigned from Flagsmith/flagsmith-front-end

At least 1 approving review is required to merge this pull request.

Assignees

@emyller emyller

Labels

api Issue related to the REST API feature New feature or request front-end Issue related to the React Front End Dashboard

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

GitLab integration: store connection credentials

2 participants

@emyller @khvn26