Open
Conversation
added 2 commits
March 25, 2023 12:15
Upstream has changed to using PDO escape, which we don't use, thus I have implemented a "dirty" addslashes escape, which works fine.
Better than my dirty addslashes escaping
Author
|
Nevermind the dirty-escape. My PHP is a bit rusty, and the way yourls deals with custom db-drivers seems somewhat weird, thus there most certainly is a better way of dealing with this, but it works and seems understandable enough. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream has changed to using PDO escape, which we don't use, thus I have implemented a "dirty" addslashes escape within a custom class, which should work fine 🤞
Feel free to do some own testing.
Also I have updated
get_resultstofetchObjects. There does not seem to be any difference in functionality, just thatget_resultshas been renamed.