v5.6.{Fuel doesn't decrease in survival mod}

[hbarreau]

Describe the bug

Hello, is it normal that fuel does not decrease in vehicles except planes? in survival mod

To Reproduce
Steps to reproduce the behaviour:

1. Take a vehicle except planes
2. Put fuel
3. Moving forward
4. Fuel doesn't decrease

Versions (please complete the following information)

• Forge: 1.12.2
• Flan's Mod: 1.12.2

[ChrisLane]

Hi, could you update your ticket with the correct version number for Flan's Mod? Likely v5.{something}

[Liruxo]

I am unable to reproduce these results.
Please verify you are using the latest content packs and FlansMod jar. If the issue persists it is recommended to use a fresh minecraft installation to rule out outdated or faulty jars and/or configuration files
Please also verify you are following these steps to install FlansMod, if not note the differences to your process

[ChrisLane]

Closing due to inactivity from the author

[ken1882]

I can confirm the issue with latest v5.6-beta.7 version, please consider reopen

Minecraft Version: 1.12.2
Forge Version: 14.23.5.2847

Mods installed:
Controlling-3.0.7.jar
Flan.s.Mod-1.12.2-5.6.0-beta.7.jar
Hwyla-1.8.26-B41_1.12.2.jar
jei_1.12.2-4.15.0.291.jar
Neat+1.4-17.jar
nodami-1.12.2-1.2.1.jar
NotEnoughIDs-1.5.4.4.jar
OptiFine_1.12.2_HD_U_E3.jar
VanillaFix-1.0.10-150.jar
XaerosWorldMap_1.5.7_Forge_1.12.jar
Xaeros_Minimap_20.9.0_Forge_1.12.jar

Steps to reproduce:

1. Create a new world, I chose superflat, cheat and bonus cheat on.
2. Using JEI to get a tank
3. Get on the tank and use JEI to get fuel, ammo, shells and fill the tank
4. Drive and shoot the monsters around for several minutes and discovered the fuel doesn't consumed at all

[Liruxo]

Are all of those mods necessary to reproduce this issue? Because it is very time consuming and difficult to debug multiple mods at once. Is JEI needed for this bug to work? does the fuel cell from the creative menu work? Can you confirm that the fuel drains as expected when only using FlansMod?

[ken1882]

Yes, using multi mc to create a new clear 1.12.2 instance with only FlansMod, WW2 and Simple Parts content pack installed, the issue still persists. Same forge version and steps to reproduce same as above. And the fuel from creative menu does work, but once it filled up the vehicle (I used Tiger II for all tests) first time, it just won't consume anymore

[ken1882]

I seems have found the bug, I cloned the repo and in the EntityVehicle.java, onUpdate method is missing the code where data.fuelInTank should be subtracted by the fuelConsumption which has appeared in EntityPlane.java and EntityMecha.java.

[ChrisLane]

Good spot @ken1882!
Perhaps the original issue was misread by @Liruxo, I was just able to reproduce this issue with a Buggy in v5.6-beta.7