Merged
Conversation
async_trigger -> trigger_event invoke_addon -> invoke_addon_sync (API breakage) async_invoke_addon -> invoke_addon
Previously, it was throwing the following error:
File mitmproxy/addons/dumper.py, line 133, in _echo_request_line
elif flow.client_conn.peername:
AttributeError: 'bool' object has no attribute 'peername'
This should improve behaviour, since calls to @Concurrent will now be serialized relative to other hooks on the same flow (but will still run in parallel with hooks on different flows). Unlike a plain async hook, @Concurrent allows blocking sync APIs to run concurrently (e.g. requests). This is patch 1/4 of the reply-ectomy.
In principle, a flow is killable as long as the connection handler is still checking the error status of the flow. This is patch 2/4 of the reply-ectomy.
This is patch 3/4 of the reply-ectomy.
The major, breaking change is that it is no longer possible to "take" a reply in order to block the effect of a later addon hook. This is patch 4/4 of the reply-ectomy.
We previously relied on the state of `Flow.reply` to check if a flow can be killed, but this doesn't work anymore with `Flow.reply` being removed. Instead, we now reintroduce the `Flow.live` attribute, which signals if we are on a live connection. Killing still is not ideal (see comment in `Flow.killable`), but this paves the way.
Support async hooks. Fixes mitmproxy#4207.
This reverts commit 278611b, which introduced a bug for the regular HTTP views, which would initially scroll to the bottom. fix mitmproxy#5089
this commit vendors urwid/urwid@e2423b5 so that we don't have to wait for a new release.
mitmproxy#5342) * Fix handling of multiple Cookie headers when proxying HTTP/2 to HTTP/1 fix mitmproxy#5337 * Add Tests about converts multiple Cookie headers to HTTP/1 from HTTP/2 * Adjust order * minor code style nits * Update CHANGELOG.md * Update _http1.py Co-authored-by: Maximilian Hils <github@maximilianhils.com>
This reverts commit c95236e.
…roxy#5366) * allow sockname to specify local-addr * set local_addr via command line * minor fix for reconfig * minor rewording Co-authored-by: Maximilian Hils <github@maximilianhils.com>
…request (mitmproxy#5374) * fix: don't generate empty chunk for head request (mitmproxy#5372) * docs: update changlog * chore: assert for optional self.request.
…itmproxy#5401) (mitmproxy#5403) Co-authored-by: Pavel <pavel@yarpg.ru>
* [mitmproxy#5428] fix huge (>65kb) http2 responses corrupted * [mitmproxy#5428] add tests for huge (>65kb) http2 responses * add changelog for mitmproxy#5428 * style fix Co-authored-by: dhabensky <dhabensky@yandex-team.ru>
8.1.1 Release Prep
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @aviau
Merge latest release of mitmproxy in our fork.
This support python 3.11 and recent dependencies version.