Skip to content

Comments

Updated listener to job:updated and waiting for job status#597

Merged
damonbanks merged 2 commits intomainfrom
fix/8089-automap-working-intermittently
Aug 27, 2024
Merged

Updated listener to job:updated and waiting for job status#597
damonbanks merged 2 commits intomainfrom
fix/8089-automap-working-intermittently

Conversation

@damonbanks
Copy link
Contributor

Closes: https://github.com/FlatFilers/Platform/issues/8089

Please explain how to summarize this PR for the Changelog:

Updated listener to job:updated from job:created to account for the mapping plan now being run asynchronously. Updated the verfiyConfidentMatching from every to some to enable more concise autoMapping

Tell code reviewer how and what to test:

@damonbanks damonbanks self-assigned this Aug 22, 2024
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 22, 2024

Walkthrough

The changes introduce enhancements to the listener functionality by integrating the automap plugin, improving automated data mapping with configurable options and robust error handling. Modifications in the AutomapService class shift the event handling to JobUpdated and add checks for job status before processing mapping plans. These updates aim to address intermittent mapping failures and streamline the control flow in handling events.

Changes

Files Change Summary
flatfilers/sandbox/src/index.ts Enhanced listener functionality with the automap plugin, adding error handling and type safety for mapping processes.
plugins/automap/src/automap.service.ts Updated event handling to JobUpdated, improved job status checks before processing mapping plans, and modified evaluation logic for mapping plans.

Assessment against linked issues

Objective Addressed Explanation
Automap should consistently map records from uploaded CSV files (#8089)
Investigate potential race conditions or underlying problems (#8089) Unclear if all race conditions have been addressed.

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4689f81 and b125d2b.

Files selected for processing (1)
  • .changeset/loud-oranges-double.md (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

): boolean {
return R.pipe(plan, (p) =>
p.fieldMapping?.every(
p.fieldMapping?.some(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carlbrugger if you see this: This makes the mapping focused on columns not the entire file. I think this change makes sense but want to confirm

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (1)
.changeset/loud-oranges-double.md (1)

5-5: Fix typographical errors in the description.

There are typographical errors in the description. Correct "verfiyConfidentMatching" to "verifyConfidentMatching" and "concice" to "concise".

Apply this diff to fix the typos:

Updated listener to job:updated from job:created to account for the mapping plan now being run asynchronously. Updated the verfiyConfidentMatching from every to some to enable more concice autoMapping
- Updated the verfiyConfidentMatching from every to some to enable more concice autoMapping
+ Updated the verifyConfidentMatching from every to some to enable more concise autoMapping

@damonbanks damonbanks changed the title Updated listern to job:updated and waiting for job status Updated listener to job:updated and waiting for job status Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants