Updated listener to job:updated and waiting for job status#597
Updated listener to job:updated and waiting for job status#597damonbanks merged 2 commits intomainfrom
Conversation
WalkthroughThe changes introduce enhancements to the listener functionality by integrating the Changes
Assessment against linked issues
Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
| ): boolean { | ||
| return R.pipe(plan, (p) => | ||
| p.fieldMapping?.every( | ||
| p.fieldMapping?.some( |
There was a problem hiding this comment.
@carlbrugger if you see this: This makes the mapping focused on columns not the entire file. I think this change makes sense but want to confirm
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
.changeset/loud-oranges-double.md (1)
5-5: Fix typographical errors in the description.There are typographical errors in the description. Correct "verfiyConfidentMatching" to "verifyConfidentMatching" and "concice" to "concise".
Apply this diff to fix the typos:
Updated listener to job:updated from job:created to account for the mapping plan now being run asynchronously. Updated the verfiyConfidentMatching from every to some to enable more concice autoMapping - Updated the verfiyConfidentMatching from every to some to enable more concice autoMapping + Updated the verifyConfidentMatching from every to some to enable more concise autoMapping
Closes: https://github.com/FlatFilers/Platform/issues/8089
Please explain how to summarize this PR for the Changelog:
Updated listener to job:updated from job:created to account for the mapping plan now being run asynchronously. Updated the
verfiyConfidentMatchingfrom every to some to enable more concise autoMappingTell code reviewer how and what to test: