Create JSON multi-sheet extractor plugin#690
Create JSON multi-sheet extractor plugin#690amarbakir wants to merge 1 commit intoFlatFilers:mainfrom
Conversation
|
Btw this might be out of place but worth noting here since it's related to tesing/validating this effort I'm pretty confident JSON extractor release 0.9.0 broke previous behavior. So if you have a working app using 0.8.2 and update to 0.9.0, the 0.9.0 JSON extractor doesn't work for both a valid, populated JSON array as well as an empty array (both cases are handled elegantly in 0.8.2). Both fail with this error Given it was a minor version update, I would expect no breaking changes. Let me know if you'd like any further details on this or help debugging/fixing |
|
@amarbakir thanks for the PR! Will take a look. On the |
|
@carlbrugger moving this over to #693 We will actually address the internal comments and AI bot comments before opening a PR back into this repo |
Please explain how to summarize this PR for the Changelog:
Tell code reviewer how and what to test:
The
plugins/json-extractorandplugins/json-multisheet-extractorplugins. Existing behavior has been keptRequirements:
{ "contacts": [ // sheet 1 { // record 1 "firstName": "John", // header 1, value "lastName": "Doe", // header 2, value "email": "john.doe@example.com" }, { // record 2 "firstName": "Jane", // header 1, value "lastName": "Smith", "email": "jane.smith@example.com" }, ], "orders": [ // sheet 2 { // record 1 "id": "ORD123456", // header 1, value "amount": 250 // header 2, value }, ] }Resulting UI somewhat supports this, but a nice next step would be to allow for a multisheet import in one step through the UI, or at the very least not require one to go back to the files list to reimport the second sheet (load data from sheet

contacts-> import data tocontacts& load data from sheetorder-> import data toorderall in one step):