Skip to content

chore: dep update#691

Merged
carlbrugger merged 3 commits intomainfrom
chore/dep-update
Nov 1, 2024
Merged

chore: dep update#691
carlbrugger merged 3 commits intomainfrom
chore/dep-update

Conversation

@carlbrugger
Copy link
Contributor

@carlbrugger carlbrugger commented Nov 1, 2024

Please explain how to summarize this PR for the Changelog:

Closes #695

Tell code reviewer how and what to test:

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 1, 2024

Walkthrough

This pull request introduces a patch update for several extractor plugins within the Flatfile ecosystem. It specifically updates the dependencies for the @flatfile/plugin-json-extractor, @flatfile/plugin-xml-extractor, @flatfile/plugin-extract-html-table, and @flatfile/plugin-extract-markdown plugins to ensure compatibility with the latest version of the @flatfile/util-extractor dependency. Additionally, it modifies a test case in the OpenAPI schema setup to reference a specific commit for consistency.

Changes

File Path Change Summary
.changeset/eighty-panthers-collect.md Updated dependency @flatfile/util-extractor in multiple plugins: @flatfile/plugin-json-extractor, @flatfile/plugin-xml-extractor, @flatfile/plugin-extract-html-table, @flatfile/plugin-extract-markdown.
plugins/openapi-schema/src/setup.factory.openapi.spec.ts Modified the URL in the generateSetup function's test case to use a specific commit reference for the OpenAPI schema.

Possibly related PRs

Suggested reviewers

  • bangarang

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 9cba025 and 4d214fa.

📒 Files selected for processing (1)
  • .changeset/eighty-panthers-collect.md (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • .changeset/eighty-panthers-collect.md

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
plugins/openapi-schema/src/setup.factory.openapi.spec.ts (1)

38-38: Add a comment explaining the commit reference.

Consider adding a comment above the URL explaining why this specific commit was chosen and what version of the OpenAPI example it represents. This will help future maintainers understand if/when they need to update it.

+          // Using OpenAPI Webhook example from v3.1 - pinned to specific commit for test stability
           source:
             'https://raw.githubusercontent.com/OAI/OpenAPI-Specification/752fbf24fc6aa4f3cd1a5b1b1247b82af8c91b6b/examples/v3.1/webhook-example.json',
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 4a530d1 and 9cba025.

📒 Files selected for processing (1)
  • plugins/openapi-schema/src/setup.factory.openapi.spec.ts (1 hunks)
🔇 Additional comments (1)
plugins/openapi-schema/src/setup.factory.openapi.spec.ts (1)

38-38: LGTM! Good practice pinning to specific commit.

Pinning the OpenAPI example to a specific commit hash improves test stability by preventing unexpected changes in the upstream repository from breaking our tests.

@carlbrugger carlbrugger merged commit ecb5496 into main Nov 1, 2024
@carlbrugger carlbrugger deleted the chore/dep-update branch November 1, 2024 16:05
@coderabbitai coderabbitai bot mentioned this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JSON extractor fails to extract any files on 0.9.0

2 participants