some catkin_lint fixes

[fmessmer]

we use catkin_lint -W 2 --strict --explain on most of our repos...and we found some complaints from flexbe_app

there are still some reports left, which I don't know whether they should be handled or ignored via --ignore uninstalled_script:

flexbe_app: warning: file 'flexbe.desktop' is executable but not installed
     *         Your package contains a file that is marked as
     * executable but not         installed. If it is a script
     * intended to be run (e.g. with rosrun), it         will not work
     * outside the devel tree. If it is not an executable
     * script, you should fix the file permissions.
     * You can ignore this problem with --ignore uninstalled_script
flexbe_app: warning: file 'nwjs/nw' is executable but not installed
flexbe_app: warning: file 'nwjs/swiftshader/libEGL.so' is executable but not installed
flexbe_app: warning: file 'nwjs/swiftshader/libGLESv2.so' is executable but not installed
flexbe_app: warning: file 'nwjs/lib/libnw.so' is executable but not installed
flexbe_app: warning: file 'nwjs/lib/libnode.so' is executable but not installed
flexbe_app: warning: file 'nwjs/lib/libffmpeg.so' is executable but not installed
catkin_lint: checked 1 packages and found 7 problems

I'm open for discussion

[pschillinger]

This sounds like a good thing to include in flexbe_ci. I will open an issue there to add the check after merging this.

• flexbe.desktop is installed on user demand by the script bin/shortcut. But I can make the file non-executable and only make the installed copy executable.
• nwjs/* executables are installed as directory, not sure why the warning is shown... any ideas?

[fmessmer]

I guess executables need to get installed into either BIN or LIB destination...SHARE might not be sufficient...

[pschillinger]

Good point, that might be the reason. However, this is intentional and required here because the nwjs executables are not intended to be used via rosrun. Instead, the file system structure is required in order to run the FlexBE App and the only way, to my knowledge, to achieve this is the share destination where also roscd brings you.

Considering this, I would actually argue that --ignore uninstalled_script would be suitable here.

[fmessmer]

@pschillinger
sorry, my focus got distracted...what is left for the PR to get it merged?