Add minimum_server_version parameter to client.request#151
Merged
Conversation
… checked when the server returns 404 - for better error message Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Flix6x
requested changes
Nov 22, 2025
Contributor
Flix6x
left a comment
Flix6x
left a comment
There was a problem hiding this comment.
Nice refactoring. Only there's a test failing.
Contributor
Author
|
I see some errors in s2 relate code and seemingly this warning is the error: "pytest.PytestRemovedIn9Warning: 'test_fill_rate_relay' requested an async fixture 'setup_cem', with no plugin or hook that handled it. This is usually an error, as pytest does not natively support it. This will turn into an error in pytest 9" |
Flix6x
approved these changes
Nov 23, 2025
Contributor
Flix6x
left a comment
Flix6x
left a comment
There was a problem hiding this comment.
Thanks for the fix. Let's handle the unrelated failing S2 test elsewhere.
nhoening
deleted the
feat/add-minimal-server-version-parameter-to-request
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There, the version will be checked when the server returns 404 - for a better error message.