Skip to content

Fix/copilot setup steps shares steps with lint and test#1998

Merged
Flix6x merged 8 commits intomainfrom
fix/copilot-setup-steps-shares-steps-with-lint-and-test
Mar 4, 2026
Merged

Fix/copilot setup steps shares steps with lint and test#1998
Flix6x merged 8 commits intomainfrom
fix/copilot-setup-steps-shares-steps-with-lint-and-test

Conversation

@Flix6x
Copy link
Contributor

@Flix6x Flix6x commented Mar 4, 2026

Description

  • Fix copilot-setup-steps.yml, which was giving errors
  • Added changelog item in documentation/changelog.rst

Look & Feel

This PR aims to make the test environment used by agents and by the lint-and-test workflow identical.

How to test

  • lint-and-test should run upon creating this PR.
  • I'm not sure if copilot uses the new copilot-setup-steps.yml until it is on main.

Flix6x added 4 commits March 3, 2026 19:57
Signed-off-by: F.N. Claessen <claessen@seita.nl>
Signed-off-by: F.N. Claessen <claessen@seita.nl>
Signed-off-by: F.N. Claessen <claessen@seita.nl>
Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x Flix6x self-assigned this Mar 4, 2026
@Flix6x Flix6x added this to the 0.32 milestone Mar 4, 2026
@Flix6x Flix6x requested a review from Copilot March 4, 2026 08:18
@read-the-docs-community
Copy link

read-the-docs-community bot commented Mar 4, 2026

Documentation build overview

📚 flexmeasures | 🛠️ Build #31656005 | 📁 Comparing bca347f against latest (eb8c218)


🔍 Preview build

Show files changed (2 files in total): 📝 2 modified | ➕ 0 added | ➖ 0 deleted
File Status
changelog.html 📝 modified
api/v3_0.html 📝 modified

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR attempts to unify the Python/PostgreSQL test environment setup between the Copilot agent setup workflow and the lint-and-test CI workflow, so both use the same installation steps.

Changes:

  • Introduces a shared “setup test environment” definition intended to be reused by multiple workflows.
  • Refactors lint-and-test and copilot-setup-steps to call that shared setup instead of duplicating steps.
  • Aligns test environment variables/healthcheck formatting for the PostgreSQL service.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
.github/workflows/setup-test-env.yml Adds a new shared setup definition (currently authored as a composite action).
.github/workflows/lint-and-test.yml Switches test job to call the shared setup definition; updates cache key and env vars.
.github/workflows/copilot-setup-steps.yml Switches Copilot setup workflow to call the shared setup definition; adds postgres/redis services and env vars.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Flix6x added 3 commits March 4, 2026 09:26
Signed-off-by: F.N. Claessen <claessen@seita.nl>
Signed-off-by: F.N. Claessen <claessen@seita.nl>
Signed-off-by: F.N. Claessen <claessen@seita.nl>
@Flix6x
Copy link
Contributor Author

Flix6x commented Mar 4, 2026

@copilot the workflow now fails on setting up the test environment with Error: Can't find 'action.yml', 'action.yaml' or 'Dockerfile' under '/home/runner/work/flexmeasures/flexmeasures/.github/actions/setup-test-env'. Did you forget to run actions/checkout before running your local action? Please fix this by committing to this PR branch. Should the reference mention setup-test-env.yml instead of setup-test-env? Finally, verify whether using the copilot-setup-steps.yml (in this branch!) works.

Copy link
Contributor

Copilot AI commented Mar 4, 2026

@Flix6x I've opened a new pull request, #1999, to work on those changes. Once the pull request is ready, I'll request review from you.

…1999)

* Initial plan

* fix: move composite action to correct location and add checkout before local action reference

Co-authored-by: Flix6x <30658763+Flix6x@users.noreply.github.com>

* fix: replace pkg_resources with importlib.metadata in visualize_data_model.py for Python 3.12 compatibility

Co-authored-by: Flix6x <30658763+Flix6x@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Flix6x <30658763+Flix6x@users.noreply.github.com>
@Flix6x Flix6x merged commit b1a7022 into main Mar 4, 2026
7 checks passed
@Flix6x Flix6x deleted the fix/copilot-setup-steps-shares-steps-with-lint-and-test branch March 4, 2026 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants