Fix/copilot setup steps shares steps with lint and test#1998
Conversation
Signed-off-by: F.N. Claessen <claessen@seita.nl>
Signed-off-by: F.N. Claessen <claessen@seita.nl>
Signed-off-by: F.N. Claessen <claessen@seita.nl>
Signed-off-by: F.N. Claessen <claessen@seita.nl>
Documentation build overview
Show files changed (2 files in total): 📝 2 modified | ➕ 0 added | ➖ 0 deleted
|
There was a problem hiding this comment.
Pull request overview
This PR attempts to unify the Python/PostgreSQL test environment setup between the Copilot agent setup workflow and the lint-and-test CI workflow, so both use the same installation steps.
Changes:
- Introduces a shared “setup test environment” definition intended to be reused by multiple workflows.
- Refactors
lint-and-testandcopilot-setup-stepsto call that shared setup instead of duplicating steps. - Aligns test environment variables/healthcheck formatting for the PostgreSQL service.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
.github/workflows/setup-test-env.yml |
Adds a new shared setup definition (currently authored as a composite action). |
.github/workflows/lint-and-test.yml |
Switches test job to call the shared setup definition; updates cache key and env vars. |
.github/workflows/copilot-setup-steps.yml |
Switches Copilot setup workflow to call the shared setup definition; adds postgres/redis services and env vars. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: F.N. Claessen <claessen@seita.nl>
Signed-off-by: F.N. Claessen <claessen@seita.nl>
Signed-off-by: F.N. Claessen <claessen@seita.nl>
|
@copilot the workflow now fails on setting up the test environment with |
…1999) * Initial plan * fix: move composite action to correct location and add checkout before local action reference Co-authored-by: Flix6x <30658763+Flix6x@users.noreply.github.com> * fix: replace pkg_resources with importlib.metadata in visualize_data_model.py for Python 3.12 compatibility Co-authored-by: Flix6x <30658763+Flix6x@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Flix6x <30658763+Flix6x@users.noreply.github.com>
Description
copilot-setup-steps.yml, which was giving errorsdocumentation/changelog.rstLook & Feel
This PR aims to make the test environment used by agents and by the lint-and-test workflow identical.
How to test
lint-and-testshould run upon creating this PR.copilot-setup-steps.ymluntil it is onmain.