Merged
Conversation
Signed-off-by: F.N. Claessen <claessen@seita.nl>
Signed-off-by: F.N. Claessen <claessen@seita.nl>
Signed-off-by: F.N. Claessen <claessen@seita.nl>
Documentation build overview
Show files changed (4 files in total): 📝 4 modified | ➕ 0 added | ➖ 0 deleted
|
Signed-off-by: F.N. Claessen <claessen@seita.nl>
Signed-off-by: F.N. Claessen <claessen@seita.nl>
Signed-off-by: F.N. Claessen <claessen@seita.nl>
Signed-off-by: F.N. Claessen <claessen@seita.nl>
Signed-off-by: F.N. Claessen <claessen@seita.nl>
Flix6x
added a commit
that referenced
this pull request
Mar 6, 2026
* fix: CLI options require serialized defaults Signed-off-by: F.N. Claessen <claessen@seita.nl> * fix: pass already deserialized config to forecaster Signed-off-by: F.N. Claessen <claessen@seita.nl> * dev: fix import issue for Python 3.10 Signed-off-by: F.N. Claessen <claessen@seita.nl> * feat: add test to cover CLI command execution with minimal options Signed-off-by: F.N. Claessen <claessen@seita.nl> * Revert "dev: fix import issue for Python 3.10" This reverts commit 1558573. * Revert "fix: pass already deserialized config to forecaster" This reverts commit 980591d. * Revert "fix: CLI options require serialized defaults" This reverts commit 1624d47. * fix: prefer tested and working forecasting CLI over CLI help type annotations Signed-off-by: F.N. Claessen <claessen@seita.nl> * style: itemize symbol Signed-off-by: F.N. Claessen <claessen@seita.nl> * docs: changelog entry Signed-off-by: F.N. Claessen <claessen@seita.nl> * docs: add release date for v0.31.1 Signed-off-by: F.N. Claessen <claessen@seita.nl> * docs: add API changelog entry Signed-off-by: F.N. Claessen <claessen@seita.nl> * docs: elaborate API changelog entry Signed-off-by: F.N. Claessen <claessen@seita.nl> --------- Signed-off-by: F.N. Claessen <claessen@seita.nl> (cherry picked from commit ccfd069) Signed-off-by: F.N. Claessen <claessen@seita.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
flexmeasures add forecastsdocumentation/changelog.rstLook & Feel
...
How to test
Run
pytest -k test_add_forecastFurther Improvements
I decided to lose the CLI option type annotations in favour of fixing the CLI command. That means when running
flexmeasures add forecasts --helpmost of the CLI options are now shown asTEXTrather than, for instance, asAwareDateTimeOrDateFieldorPlanningDurationField. I have not yet figured out a long-term solution for this.Related Items
Closes #2005