Search delay

[taooceros]

For What?

• For plug-ins with loading until results appear, such as translation or youtube (receving data from web). Each typing tries to load the results, causing a delay in typing.
• e.g : tr h(stuck)e(stuck)l(stuck)l(stuck)o(stuck)...
• To address this issue, this pr provides a setting to load the results after a certain period of time after typing stops rather than every typing.

What's the PR

• Default Delay setting is possible in Flow. The default is 50 ms.
• 50ms / 100ms / 150ms.
• The plug-in creator can set the delay. In this case, the delay value by the plug-in takes precedence.
• Resolve Add input box input anti-shake function #1322
• If there is no delay specified by the plug-in, use the default value for flow.
• Each delay operates on a per-plug-in basis.

Test Cases

• When entering a query, the result window must be displayed at the appropriate speed for each delay.
• If delay is defined in the plug-in, the plug-in delay is applied.

References

[taooceros]

This is for a better concurrency so we don't really need to do a context switch

[jjw24]

If delay is defined in the plug-in, the plug-in delay is applied.

Is this tested?

[taooceros]

If delay is defined in the plug-in, the plug-in delay is applied.

Is this tested?

I test it

[jjw24]

I am running into issue with this sort of result on the default delay:

Is it possible to have no delay?

[jjw24]

Another one I am finding is using the default delay if you type dddddddddddddddddddddddddddd then delete it one by one, the trailing query suggestion text makes it feel really slow, like there is a bit of lag almost. On a prd release the trailing query suggestion text is removed a lot faster.

[jjw24]

Correct me if I am wrong PRD has no query delay at all right?

[taooceros]

I am running into issue with this sort of result on the default delay:

Is it possible to have no delay?

I don't think this makes sense, because the current query model also have 45ms delay for global query. How fast do you type?

[taooceros]

Another one I am finding is using the default delay if you type dddddddddddddddddddddddddddd then delete it one by one, the trailing query suggestion text makes it feel really slow, like there is a bit of lag almost. On a prd release the trailing query suggestion text is removed a lot faster.

could you try run without debugger? the debugger makes thing much slower

[VictoriousRaptor]

Is it possible for non global plugins to notify that should use user specified delay value?

[VictoriousRaptor]

And why use delay only for global searches?

[VictoriousRaptor]

Should we delay when typing the FIRST character?

[github-actions]

@check-spelling-bot Report

🔴 Please review

See the 📂 files view or the 📜action log for details.

Unrecognized words (22)

ASponsor
combobox
embeded
happlebao
installbtn
IPublic
mainwindow
metadatas
Mvvm
otalcmd
overriden
Preinstalled
receving
Reloadable
scm
settingwindow
Txb
uninstallbtn
updatebtn
viewupdate
Wpf
ZIndex

To accept ✔️ these unrecognized words as correct and remove the previously acknowledged and now absent words, run the following commands

... in a clone of the git@github.com:Flow-Launcher/Flow.Launcher.git repository
on the search_delay branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/Flow-Launcher/Flow.Launcher/actions/runs/3938000201/attempts/1'

To have the bot do this for you, reply quoting the following line:
@check-spelling-bot apply updates.

If the flagged items are 🤯 false positives

If items relate to a ...

• binary file (or some other file you wouldn't want to check at all).

  Please add a file path to the excludes.txt file matching the containing file.

  File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

  ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

• well-formed pattern.

  If you can write a pattern that would match it,
  try adding it to the patterns.txt file.

  Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

  Note that patterns can't match multiline strings.

[jjw24]

I am running into issue with this sort of result on the default delay:

Is it possible to have no delay?

I don't think this makes sense, because the current query model also have 45ms delay for global query. How fast do you type?

I dont type that fast, but this is done with my normal speed.

[jjw24]

Another one I am finding is using the default delay if you type dddddddddddddddddddddddddddd then delete it one by one, the trailing query suggestion text makes it feel really slow, like there is a bit of lag almost. On a prd release the trailing query suggestion text is removed a lot faster.

could you try run without debugger? the debugger makes thing much slower

This was tested not with debugger but an actual build, are you able to see what I am describing?

[taooceros]

you mean this?

[taooceros]

What about removing the autosuggestion whenever query change?

[taooceros]

Should we delay when typing the FIRST character?

huh maybe not

[Jack251970]

Closed for #3350.