Fix incomplete IPv6 regex patterns for compressed addresses#4187
Closed
Copilot wants to merge 2 commits intofix-url-regex-filterfrom
Closed
Fix incomplete IPv6 regex patterns for compressed addresses#4187Copilot wants to merge 2 commits intofix-url-regex-filterfrom
Copilot wants to merge 2 commits intofix-url-regex-filterfrom
Conversation
…dresses Co-authored-by: VictoriousRaptor <10308169+VictoriousRaptor@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP Address feedback on UrlPattern update
Fix incomplete IPv6 regex patterns for compressed addresses
Dec 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The IPv6 regex patterns failed to match valid compressed addresses when
::appears mid-address with multiple segments on both sides (e.g.,fe80:1:2::3:4:5:6).Changes
::positions (1-6 groups before, 1-6 groups after) instead of the previous limited set2001:db8::matching when input is2001:db8::1)[IPv6]and non-bracketed patternsImplementation
The fix enumerates all valid IPv6 compression positions. For example:
Note: In
(?:[0-9a-fA-F]{1,4}:){6}:, the quantified group already includes trailing colons (matchinga:b:c:d:e:f:), so a single:suffix correctly produces::.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.