-
-
Notifications
You must be signed in to change notification settings - Fork 556
Support relative paths for Python/Node.js executables #4230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Jack251970
wants to merge
19
commits into
dev
Choose a base branch
from
copilot/support-relative-paths
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+46
−6
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
438bb8a
Initial plan
Copilot d61ec18
Add relative path resolution support for Python and Node.js executables
Copilot 864eedd
Add UI descriptions for relative path support
Copilot 3de9e53
Address code review feedback: convert absolute to relative paths for …
Copilot ab5a0b4
Revert "Add UI descriptions for relative path support"
Jack251970 c59249d
Save Python/Node paths as absolute, not relative
Jack251970 9070ff4
Remove PathResolutionTest.cs and related path tests
Jack251970 d16e43d
Refactor path utilities to DataLocation from Constant
Jack251970 d49e5b4
Remove unused Flow.Launcher.Infrastructure using directive
Jack251970 9fa4c37
Remove relative path conversion for plugin settings files
Jack251970 001101b
Improve error handling
Jack251970 34a984c
Improve code comments
Jack251970 b923c40
Merge branch 'dev' into copilot/support-relative-paths
Jack251970 9b0a503
Clarify exception type in path resolution catch block
Jack251970 d62fd05
Ensure the path is updated in settings in case user has moved Flow to…
Jack251970 04a56b5
Use Path.IsPathFullyQualified for absolute path check
Jack251970 57fde0a
Improve code comments
Jack251970 bfed516
Improve code comments
Jack251970 f756b71
Catch all exceptions
Jack251970 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.