Enable TwoWay binding for MaxSuggestions NumberBox

[Jack251970]

Follow on with #4198

Changed NumberBox binding for Settings.MaxSuggestions from OneWay to TwoWay, allowing user input in the UI to update the underlying setting. This ensures changes made by users are saved back to the settings model.

---

Summary by cubic

Fixes the MaxSuggestions setting not persisting when edited in the Web Search settings. In SettingsControl.xaml, switches the NumberBox Value binding from OneWay to TwoWay so user input updates Settings.MaxSuggestions; closes the bug where changes were not saved.

^{Written for commit 72269db. Summary will update on new commits.}

[gitstream-cm]

🥷 Code experts: jjw24

jjw24, Jack251970 have most 👩‍💻 activity in the files.
jjw24, Jack251970 have most 🧠 knowledge in the files.

See details

Plugins/Flow.Launcher.Plugin.WebSearch/SettingsControl.xaml

Activity based on git-commit:

	jjw24	Jack251970
FEB
JAN		45 additions & 45 deletions
DEC
NOV
OCT		25 additions & 17 deletions
SEP

Knowledge based on git-blame:
jjw24: 67%
Jack251970: 31%

✨ Comment /gs review for LinearB AI review. Learn how to automate it here.

[cubic-dev-ai]

No issues found across 1 file

[gitstream-cm]

Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ffa974b and c9baab7.

📒 Files selected for processing (1)

• Plugins/Flow.Launcher.Plugin.WebSearch/SettingsControl.xaml

---

📝 Walkthrough

Walkthrough

The change modifies a single XAML binding in the WebSearch plugin's settings control, switching the NumberBox binding mode for MaxSuggestions from OneWay to TwoWay. This enables bidirectional data flow, allowing UI changes to propagate back to the settings model.

Changes

Cohort / File(s)	Summary
WebSearch Settings UI Plugins/Flow.Launcher.Plugin.WebSearch/SettingsControl.xaml	Changed NumberBox binding mode for MaxSuggestions from OneWay to TwoWay, enabling updates from the UI to persist back to the Settings object.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

• Add max suggestions limit for web search plugin #4198: Directly related fix for the same SettingsControl.xaml NumberBox binding to ensure UI changes propagate to Settings.MaxSuggestions.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: enabling TwoWay binding for the MaxSuggestions NumberBox, which matches the single file modification in the changeset.
Description check	✅ Passed	The description clearly explains the binding change from OneWay to TwoWay and its purpose of persisting user input to settings, directly corresponding to the changeset modifications.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch websearch_ui

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

Updates the WebSearch plugin settings UI so the MaxSuggestions NumberBox writes user-entered values back to the underlying Settings.MaxSuggestions property, ensuring the setting can be persisted when changed via the UI.

Changes:

• Switched the MaxSuggestions NumberBox Value binding from OneWay to TwoWay.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[jjw24]

Thank you for the fix 👍