Fix Explorer plugin Quick Access items missing from general search results

[Jack251970]

Follow on with #4093

Resolve #4287

---

Summary by cubic

Fixes a 2.1.0 regression where Quick Access items were missing from Explorer plugin general search. Matching Quick Access links are now always merged into results, regardless of the action keyword. Closes #4287.

• Bug Fixes
  • Removed the incorrect QuickAccessKeywordEnabled check in GetQuickAccessResultsFilteredByActionKeyword.
  • The action keyword now only controls Quick Access–only searches; general searches include matching Quick Access items.

^{Written for commit ae73b48. Summary will update on new commits.}

[gitstream-cm]

🥷 Code experts: jjw24

jjw24 has most 👩‍💻 activity in the files.
jjw24 has most 🧠 knowledge in the files.

See details

Plugins/Flow.Launcher.Plugin.Explorer/Search/SearchManager.cs

Activity based on git-commit:

	jjw24
FEB
JAN
DEC
NOV
OCT
SEP

Knowledge based on git-blame:
jjw24: 59%

✨ Comment /gs review for LinearB AI review. Learn how to automate it here.

[gitstream-cm]

Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX.

[cubic-dev-ai]

No issues found across 1 file

[coderabbitai]

📝 Walkthrough

Walkthrough

Removed an early return guard in the GetQuickAccessResultsFilteredByActionKeyword method that prevented Quick Access results from being computed when the Quick Access keyword feature was disabled, allowing results to be consistently processed subject to downstream filtering.

Changes

Cohort / File(s)	Summary
Quick Access Results Processing Plugins/Flow.Launcher.Plugin.Explorer/Search/SearchManager.cs	Removed conditional guard that skipped Quick Access result computation when Settings.QuickAccessKeywordEnabled was false, ensuring results are always generated and filtered downstream instead.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

• BUG: Explorer plugin navigate path should only show results in current path #4053: Modifies SearchManager.cs control flow around Quick Access result computation and merging, affecting when Quick Access results are produced and returned.
• [FEATURE] Folder and File Action Keywords #4093: Modifies SearchManager.cs's Quick Access handling in GetQuickAccessResultsFilteredByActionKeyword and action-keyword-driven filtering logic.

Suggested reviewers

• jjw24

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main bug fix: restoring Quick Access items to general search results in the Explorer plugin.
Linked Issues check	✅ Passed	The pull request directly addresses issue #4287 by removing the incorrect QuickAccessKeywordEnabled guard that prevented Quick Access items from appearing in general search results.
Out of Scope Changes check	✅ Passed	The changes are focused solely on fixing the Quick Access regression reported in issue #4287; no unrelated modifications are present.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check	✅ Passed	The PR description clearly identifies the issue (Quick Access regression in 2.1.0), references relevant issues (#4093, #4287), and explains the fix (removing incorrect QuickAccessKeywordEnabled check).

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch copilot/fix-quick-access-items-bug

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

Fixes Explorer plugin behavior where Quick Access items were missing from general (non–Quick Access keyword) search results, addressing the regression reported in #4287 after the action-keyword filtering refactor in #4093.

Changes:

• Always include Quick Access matches in the merged result set for non-path searches (instead of gating on QuickAccessKeywordEnabled).
• Keep action-keyword-based result-type filtering applied to merged Quick Access results.

Comments suppressed due to low confidence (1)

Plugins/Flow.Launcher.Plugin.Explorer/Search/SearchManager.cs:309

• This change alters behavior so Quick Access links are merged into general search results even when the Quick Access action keyword is disabled. Please add/adjust a unit test to lock in the intended behavior (e.g., SearchAsync with SearchActionKeyword enabled, QuickAccessKeywordEnabled=false, and a QuickAccess link that matches the query should still be returned).

        private List<Result> GetQuickAccessResultsFilteredByActionKeyword(Query query, List<ActionKeyword> actions)
        {
            var results = QuickAccess.AccessLinkListMatched(query, Settings.QuickAccessLinks);
            if (results.Count == 0)
                return [];

            return results
                .Where(r => r.ContextData is SearchResult result
                       && !IsResultTypeFilteredByActionKeyword(result.Type, actions))
                .ToList();

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.