Add Crowdin translation links to settings pages#4395
Conversation
Added Crowdin project URL constant and resource string. Exposed Crowdin link in About and General settings via new properties and hyperlink buttons, encouraging users to help translate Flow.
|
🥷 Code experts: no user but you matched threshold 10 Jack251970 has most 👩💻 activity in the files. See details
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame:
Activity based on git-commit:
Knowledge based on git-blame: ✨ Comment |
|
Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 6 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="Flow.Launcher/SettingPages/Views/SettingsPaneAbout.xaml">
<violation number="1" location="Flow.Launcher/SettingPages/Views/SettingsPaneAbout.xaml:80">
P2: Use a localized resource key for the hyperlink text instead of a hardcoded "Crowdin" string.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds Crowdin translation links: new constant for the Crowdin project URL, two English localization strings, Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
Flow.Launcher/SettingPages/Views/SettingsPaneAbout.xaml (1)
80-80: Use a resource key for the “Crowdin” label for i18n consistency.Line 80 is hardcoded while adjacent link labels are localized resources. Consider moving this label to language resources too.
Proposed change
- <ui:HyperlinkButton Content="Crowdin" NavigateUri="{Binding Crowdin}" /> + <ui:HyperlinkButton Content="{DynamicResource crowdin}" NavigateUri="{Binding Crowdin}" />🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@Flow.Launcher/SettingPages/Views/SettingsPaneAbout.xaml` at line 80, Replace the hardcoded "Crowdin" label on the HyperlinkButton with a localized resource reference to match adjacent links: locate the HyperlinkButton with Content="Crowdin" and NavigateUri="{Binding Crowdin}" in SettingsPaneAbout.xaml and change its Content to use the same resource approach used by other link labels (e.g., a StaticResource or x:Uid/resource binding for the "Crowdin" display text), then add the corresponding resource key (e.g., CrowdinLabel) to the language resource files so the label is localized.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@Flow.Launcher/Languages/en.xaml`:
- Line 147: The resource key HelpUsTranslateFlow is defined only in en.xaml
causing missing-key labels in other language resource dictionaries; add a
matching <system:String x:Key="HelpUsTranslateFlow">…</system:String> entry to
each of the 26 shipped language XAML files (ar, cs, da, de, es, es-419, fr, he,
it, ja, ko, nb, nb-NO, nl, pl, pt-br, pt-pt, ru, sk, sr, sr-Cyrl-RS, tr, uk-UA,
vi, zh-cn, zh-tw) using the correct localized translation where available or the
English text "Help us translate Flow" as a fallback, ensuring the key name
HelpUsTranslateFlow exactly matches the one in Flow.Launcher/Languages/en.xaml
so the ResourceDictionary lookup succeeds for all locales.
---
Nitpick comments:
In `@Flow.Launcher/SettingPages/Views/SettingsPaneAbout.xaml`:
- Line 80: Replace the hardcoded "Crowdin" label on the HyperlinkButton with a
localized resource reference to match adjacent links: locate the HyperlinkButton
with Content="Crowdin" and NavigateUri="{Binding Crowdin}" in
SettingsPaneAbout.xaml and change its Content to use the same resource approach
used by other link labels (e.g., a StaticResource or x:Uid/resource binding for
the "Crowdin" display text), then add the corresponding resource key (e.g.,
CrowdinLabel) to the language resource files so the label is localized.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 2541676a-7df4-44f9-9bf8-098c6da5c145
📒 Files selected for processing (6)
Flow.Launcher.Infrastructure/Constant.csFlow.Launcher/Languages/en.xamlFlow.Launcher/SettingPages/ViewModels/SettingsPaneAboutViewModel.csFlow.Launcher/SettingPages/ViewModels/SettingsPaneGeneralViewModel.csFlow.Launcher/SettingPages/Views/SettingsPaneAbout.xamlFlow.Launcher/SettingPages/Views/SettingsPaneGeneral.xaml
There was a problem hiding this comment.
Pull request overview
Adds a Crowdin project link to the settings UI so users can easily navigate to the translation project from both General (near language selection) and About pages.
Changes:
- Introduced
Constant.CrowdinProjectUrland exposed it via newCrowdinproperties on the About and General settings view models. - Added a “Help us translate Flow” hyperlink next to the language selector on the General settings page.
- Added a Crowdin hyperlink to the About page links section and introduced a new English resource string.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Flow.Launcher/SettingPages/Views/SettingsPaneGeneral.xaml | Adds a translation hyperlink alongside the language dropdown. |
| Flow.Launcher/SettingPages/Views/SettingsPaneAbout.xaml | Adds a Crowdin hyperlink to the About page link list. |
| Flow.Launcher/SettingPages/ViewModels/SettingsPaneGeneralViewModel.cs | Exposes Crowdin URL for binding in General settings view. |
| Flow.Launcher/SettingPages/ViewModels/SettingsPaneAboutViewModel.cs | Exposes Crowdin URL for binding in About settings view. |
| Flow.Launcher/Languages/en.xaml | Adds the HelpUsTranslateFlow resource string. |
| Flow.Launcher.Infrastructure/Constant.cs | Adds the Crowdin project URL constant. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Added "crowdin" string resource to en.xaml for localization. Updated SettingsPaneAbout.xaml to use the localized resource for the Crowdin hyperlink button instead of a hardcoded label.
coderabbitai
bot
removed
bug
Added Crowdin project URL constant and resource string. Exposed Crowdin link in About and General settings via new properties and hyperlink buttons, encouraging users to help translate Flow.
Summary by cubic
Add Crowdin translation links to About and General settings so users can help translate Flow. Introduces a shared Crowdin URL constant and localized labels for both pages.
crowdinresource (no hardcoded text).Constant.CrowdinProjectUrl;HelpUsTranslateFlowandcrowdinresource strings;Crowdinproperties in About and General view models; hyperlink buttons in About and General settings.Written for commit b06680b. Summary will update on new commits.